refactoring

Author: fglock

src/main/java/org/perlonjava/parser/StatementParser.java

@@ -308,14 +308,14 @@ public static Node parseUseDeclaration(Parser parser, LexerToken token) {
                         // If the specified Perl version is 5.12 or higher,
                         // strictures are enabled lexically.
                         useStrict(new RuntimeArray(
-                                List.of(new RuntimeScalar("strict"))), RuntimeContextType.VOID);
+                                new RuntimeScalar("strict")), RuntimeContextType.VOID);
                     }
                     if (minorVersion >= 35) {
                         // If the specified Perl version is 5.35.0 or higher,
                         // warnings are enabled.
                         useWarnings(new RuntimeArray(
-                                List.of(new RuntimeScalar("warnings"),
-                                        new RuntimeScalar("all"))), RuntimeContextType.VOID);
+                                new RuntimeScalar("warnings"),
+                                new RuntimeScalar("all")), RuntimeContextType.VOID);
                     }
                 }
             }

src/main/java/org/perlonjava/perlmodule/FileSpec.java

@@ -274,7 +274,7 @@ public static RuntimeList splitpath(RuntimeArray args, int ctx) {
         }
 
         return new RuntimeList(
-                List.of(new RuntimeScalar(volume), new RuntimeScalar(directory), new RuntimeScalar(file)));
+                new RuntimeScalar(volume), new RuntimeScalar(directory), new RuntimeScalar(file));
     }
 
     /**

src/main/java/org/perlonjava/perlmodule/Json.java

@@ -115,7 +115,7 @@ public static RuntimeList encode_json(RuntimeArray args, int ctx) {
                     RuntimeContextType.SCALAR)
                         .elements.getFirst();
         return encode(
-                new RuntimeArray(List.of(jsonObject, perlData)),
+                new RuntimeArray(jsonObject, perlData),
                 RuntimeContextType.SCALAR);
     }
 

src/main/java/org/perlonjava/runtime/RuntimeArray.java

@@ -36,6 +36,16 @@ public RuntimeArray(List<RuntimeScalar> list) {
         this.elements = new ArrayList<>(list);
     }
 
+    public RuntimeArray(RuntimeBaseEntity... values) {
+        this.elements = new ArrayList<>();
+        for (RuntimeBaseEntity value : values) {
+            Iterator<RuntimeScalar> iterator = value.iterator();
+            while (iterator.hasNext()) {
+                this.elements.add(iterator.next());
+            }
+        }
+    }
+
     /**
      * Constructs a RuntimeArray from a RuntimeList.
      *

src/main/java/org/perlonjava/runtime/RuntimeHash.java

@@ -94,7 +94,7 @@ public RuntimeScalar addToScalar(RuntimeScalar scalar) {
     public RuntimeArray setFromList(RuntimeList value) {
         RuntimeHash hash = createHash(value);
         this.elements = hash.elements;
-        return new RuntimeArray(new RuntimeList(this));
+        return new RuntimeArray(this);
     }
 
     /**
@@ -291,10 +291,7 @@ public RuntimeList each() {
             hashIterator = iterator();
         }
         if (hashIterator.hasNext()) {
-            RuntimeList list = new RuntimeList();
-            list.elements.add(hashIterator.next());
-            list.elements.add(hashIterator.next());
-            return list;
+            return new RuntimeList(hashIterator.next(), hashIterator.next());
         }
         hashIterator = null;
         return new RuntimeList();

src/main/java/org/perlonjava/runtime/RuntimeList.java

@@ -22,6 +22,16 @@ public RuntimeList(List<RuntimeScalar> list) {
         this.elements = new ArrayList<>(list);
     }
 
+    public RuntimeList(RuntimeBaseEntity... values) {
+        this.elements = new ArrayList<>();
+        for (RuntimeBaseEntity value : values) {
+            Iterator<RuntimeScalar> iterator = value.iterator();
+            while (iterator.hasNext()) {
+                this.elements.add(iterator.next());
+            }
+        }
+    }
+
     /**
      * Constructs a RuntimeList with a single scalar value.
      *

src/main/java/org/perlonjava/runtime/RuntimeScalar.java

@@ -163,14 +163,12 @@ public static RuntimeList caller(RuntimeList args, int ctx) {
     }
 
     public static RuntimeList reset(RuntimeList args, int ctx) {
-        RuntimeList res = new RuntimeList();
         if (args.elements.isEmpty()) {
             RuntimeRegex.reset();
         } else {
             throw new PerlCompilerException("not implemented: reset(args)");
         }
-        res.add(getScalarInt(1));
-        return res;
+        return getScalarInt(1).getList();
     }
 
     public RuntimeScalar exit() {

src/main/java/org/perlonjava/runtime/RuntimeVecLvalue.java

@@ -56,13 +56,10 @@ public RuntimeScalar set(RuntimeScalar value) {
 
         int newValue = value.getInt();
 
-        // Create arguments for Vec.set method
-        RuntimeList args = new RuntimeList();
-        args.elements.add(lvalue);
-        args.elements.add(new RuntimeScalar(offset));
-        args.elements.add(new RuntimeScalar(bits));
-
         try {
+            // Create arguments for Vec.set method
+            RuntimeList args = new RuntimeList(
+                    lvalue, new RuntimeScalar(offset), new RuntimeScalar(bits));
             // Use Vec.set to update the parent string
             Vec.set(args, new RuntimeScalar(newValue));
         } catch (PerlCompilerException e) {