O2 linter

Please consider the following formatting changes to #11877 #130

Sign in to view logs

Triggered via pull request July 2, 2025 14:41

alibuild

opened #128

Status Failure

Total duration 13s

Artifacts –

o2-linter.yml

on: pull_request_target

Annotations

10 errors and 2 notices

[pwghf/struct-member-order]: EventFiltering/PWGHF/HFFilter.cxx#L192

HfFilter: HistogramRegistry appears too early (before end of PresliceUnsorted<).

[pwghf/struct-member-order]: EventFiltering/PWGHF/HFFilter.cxx#L161

HfFilter: Service< appears too early (before end of Configurable<).

[name/configurable]: EventFiltering/PWGHF/HFFilter.cxx#L162

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)

[name/workflow-file]: EventFiltering/PWGHF/HFFilter.cxx#L1

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L1779

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L1457

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L1230

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L511

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L432

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

[magic-number]: EventFiltering/PWGHF/HFFilter.cxx#L285

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".

Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.