Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join-standalone-tags doesn't follow mustache spec #60

Open
ghost opened this issue May 29, 2018 · 0 comments
Open

join-standalone-tags doesn't follow mustache spec #60

ghost opened this issue May 29, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented May 29, 2018

Hi Felix,

Thanks for making clostache, I've really enjoyed using it!

While tracking down a bug in my code, I realized that partials on their own lines don't save the newline at the end of partial, instead replacing it with whatever the partial contains, and looking through the clostache source, I found join-standalone-tags, which seemed the likely source of this behavior.

The commit messages for that function didn't give a lot of context for why this change was made, but it looks like this no longer follows the mustache spec for partials, which I found here. The overview of the partials spec doesn't define how to handle newlines at the EOL in the case of standalone partials, however, the test for the spec -- line 54 -- shows it as keeping the newlines at the end of standalone partials.

Is this the desired behavior for partials in clostache?

Thank you,
Evan

@ghost ghost changed the title join-standalone-tags doesn't follow moustache spec join-standalone-tags doesn't follow mustache spec May 29, 2018
@ghost ghost changed the title join-standalone-tags doesn't follow mustache spec join-standalone-tags doesn't follow mustache spec May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants