[BugFix] Fix the concurrency bug of str_to_map (StarRocks#43901)

Signed-off-by: trueeyu <[email protected]>

Author: trueeyu

be/src/exprs/str_to_map.cpp

@@ -36,14 +36,20 @@ StatusOr<ColumnPtr> StringFunctions::str_to_map(FunctionContext* context, const
 
     // split first
     Columns split_columns{columns[0], columns[1]};
-    RETURN_IF_ERROR(StringFunctions::split_prepare(context, FunctionContext::FRAGMENT_LOCAL));
     ASSIGN_OR_RETURN(auto splited, StringFunctions::split(context, split_columns));
-    RETURN_IF_ERROR(StringFunctions::split_close(context, FunctionContext::FRAGMENT_LOCAL));
 
     Columns splited_columns{splited, columns[2]};
     return str_to_map_v1(context, splited_columns);
 }
 
+Status StringFunctions::str_to_map_prepare(FunctionContext* context, FunctionContext::FunctionStateScope scope) {
+    return StringFunctions::split_prepare(context, FunctionContext::FRAGMENT_LOCAL);
+}
+
+Status StringFunctions::str_to_map_close(FunctionContext* context, FunctionContext::FunctionStateScope scope) {
+    return StringFunctions::split_close(context, FunctionContext::FRAGMENT_LOCAL);
+}
+
 /**
 * @param: [array_string, delimiter]
 * @paramType: [ArrayBinaryColumn, BinaryColumn]

be/src/exprs/string_functions.h

@@ -356,6 +356,8 @@ class StringFunctions {
     * @return: MapColumn map<string,string>
     */
     DEFINE_VECTORIZED_FN(str_to_map);
+    static Status str_to_map_prepare(FunctionContext* context, FunctionContext::FunctionStateScope scope);
+    static Status str_to_map_close(FunctionContext* context, FunctionContext::FunctionStateScope scope);
 
     /**
      * @param: [string_value, delimiter, field]

gensrc/script/functions.py

@@ -328,7 +328,7 @@
     [30316, 'str_to_map', True, False, 'MAP_VARCHAR_VARCHAR', ['ARRAY_VARCHAR', 'VARCHAR'],
      'StringFunctions::str_to_map_v1'],
     [30317, 'str_to_map', True, False, 'MAP_VARCHAR_VARCHAR', ['VARCHAR', 'VARCHAR', 'VARCHAR'],
-     'StringFunctions::str_to_map'],
+     'StringFunctions::str_to_map', 'StringFunctions::str_to_map_prepare', 'StringFunctions::str_to_map_close'],
 
     [30320, 'regexp_extract', True, False, 'VARCHAR', ['VARCHAR', 'VARCHAR', 'BIGINT'],
      'StringFunctions::regexp_extract',

test/sql/test_function/R/test_str_to_map

@@ -0,0 +1,11 @@
+-- name: test_str_to_map
+CREATE TABLE t1(c1 INT, c2 STRING) DUPLICATE KEY(c1) DISTRIBUTED BY HASH(c1) BUCKETS 20;
+-- result:
+-- !result
+insert into t1 select generate_series, generate_series from TABLE(generate_series(1, 10000));
+-- result:
+-- !result
+select sum(cardinality(str_to_map(c2, ",", ":"))) from t1;
+-- result:
+10000
+-- !result

test/sql/test_function/T/test_str_to_map

@@ -0,0 +1,7 @@
+-- name: test_str_to_map
+
+CREATE TABLE t1(c1 INT, c2 STRING) DUPLICATE KEY(c1) DISTRIBUTED BY HASH(c1) BUCKETS 20;
+
+insert into t1 select generate_series, generate_series from TABLE(generate_series(1, 10000));
+
+select sum(cardinality(str_to_map(c2, ",", ":"))) from t1;