Skip to content

Commit 3490554

Browse files
committed
run formatter.
1 parent ddec20c commit 3490554

File tree

4 files changed

+2
-16
lines changed

4 files changed

+2
-16
lines changed

spec/runtime/manifest.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ describe("initScheduleTrigger", () => {
286286
expect(st).to.deep.eq({
287287
schedule: "every 30 minutes",
288288
timeZone: RESET_VALUE,
289-
attemptDeadlineSeconds: RESET_VALUE,
290289
retryConfig: {
291290
retryCount: RESET_VALUE,
292291
maxDoublings: RESET_VALUE,

spec/v2/providers/scheduler.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import { runHandler } from "../../helper";
3232
const MINIMAL_SCHEDULE_TRIGGER: ManifestEndpoint["scheduleTrigger"] = {
3333
schedule: "",
3434
timeZone: options.RESET_VALUE,
35-
attemptDeadlineSeconds: options.RESET_VALUE,
3635
retryConfig: {
3736
retryCount: options.RESET_VALUE,
3837
maxRetrySeconds: options.RESET_VALUE,
@@ -130,7 +129,6 @@ describe("schedule", () => {
130129
scheduleTrigger: {
131130
schedule: "* * * * *",
132131
timeZone: "utc",
133-
attemptDeadlineSeconds: 300,
134132
retryConfig: {
135133
retryCount: 3,
136134
maxRetrySeconds: 10,

src/runtime/manifest.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ export interface ManifestEndpoint {
9797
scheduleTrigger?: {
9898
schedule: string | Expression<string>;
9999
timeZone?: string | Expression<string> | ResetValue;
100-
attemptDeadlineSeconds?: number | Expression<number> | ResetValue;
101100
retryConfig?: {
102101
retryCount?: number | Expression<number> | ResetValue;
103102
maxRetrySeconds?: string | Expression<string> | ResetValue;
@@ -260,14 +259,12 @@ const RESETTABLE_V1_SCHEDULE_OPTIONS: Omit<
260259
const RESETTABLE_V2_SCHEDULE_OPTIONS: Omit<
261260
ResettableKeys<ManifestEndpoint["scheduleTrigger"]["retryConfig"]>,
262261
"maxRetryDuration" | "maxBackoffDuration" | "minBackoffDuration"
263-
> &
264-
Pick<ResettableKeys<ManifestEndpoint["scheduleTrigger"]>, "attemptDeadlineSeconds"> = {
262+
> = {
265263
retryCount: null,
266264
maxDoublings: null,
267265
maxRetrySeconds: null,
268266
minBackoffSeconds: null,
269267
maxBackoffSeconds: null,
270-
attemptDeadlineSeconds: null,
271268
};
272269

273270
function initScheduleTrigger(
@@ -281,11 +278,7 @@ function initScheduleTrigger(
281278
};
282279
if (opts.every((opt) => !opt?.preserveExternalChanges)) {
283280
for (const key of Object.keys(resetOptions)) {
284-
if (key === "attemptDeadlineSeconds") {
285-
scheduleTrigger[key] = RESET_VALUE;
286-
} else {
287-
scheduleTrigger.retryConfig[key] = RESET_VALUE;
288-
}
281+
scheduleTrigger.retryConfig[key] = RESET_VALUE;
289282
}
290283
scheduleTrigger = { ...scheduleTrigger, timeZone: RESET_VALUE };
291284
}

src/v2/providers/scheduler.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ export interface ScheduleOptions extends options.GlobalOptions {
111111
/** The timezone that the schedule executes in. */
112112
timeZone?: timezone | Expression<string> | ResetValue;
113113

114-
115114
/** The number of retry attempts for a failed run. */
116115
retryCount?: number | Expression<number> | ResetValue;
117116

@@ -198,9 +197,6 @@ export function onSchedule(
198197
};
199198

200199
copyIfPresent(ep.scheduleTrigger, separatedOpts, "timeZone");
201-
if (ep.timeoutSeconds) {
202-
ep.scheduleTrigger.attemptDeadlineSeconds = ep.timeoutSeconds;
203-
}
204200
copyIfPresent(
205201
ep.scheduleTrigger.retryConfig,
206202
separatedOpts.retryConfig,

0 commit comments

Comments
 (0)