[99PCT] Added percentile 99 to upper metric

Author: TomMizrachi

debian/control

@@ -1,5 +1,5 @@
 Package: brubeck-fiverr
-Version: 1.0.11
+Version: 1.0.12
 Maintainer: Fiverr.com
 Architecture: amd64
 Description: A Statsd-compatible metrics aggregator (https://github.com/fiverr/brubeck)

src/histogram.c

@@ -91,6 +91,7 @@ void brubeck_histo_sample(
 	histo_sort(histo);
 
 	value_t pct_rank = histo_percentile_rank(histo, 0.9f);
+	value_t pct_rank_99 = histo_percentile_rank(histo, 0.99f);
 
 	sample->count = histo->count;
 	sample->count_90 = floor((histo->count * 0.9) + 0.5f);
@@ -99,6 +100,7 @@ void brubeck_histo_sample(
 	sample->lower = histo->values[0];
 	sample->upper = histo->values[histo->size - 1];
 	sample->upper_90 = histo->values[(size_t)pct_rank - 1];
+	sample->upper_99 = histo->values[(size_t)pct_rank_99 - 1];
 	sample->mean = sample->sum / histo->count;
 	sample->mean_90 = sample->sum_90 / sample->count_90;
 	sample->median = histo_percentile(histo, 0.5f);

src/histogram.h

@@ -19,6 +19,7 @@ struct brubeck_histo_sample {
 	value_t sum_90;
 	value_t upper;
 	value_t upper_90;
+	value_t upper_99;
 };
 
 void brubeck_histo_push(struct brubeck_histo *histo, value_t value, value_t sample_rate);

src/metric.c

@@ -223,6 +223,10 @@ histogram__sample(struct brubeck_metric *metric, brubeck_sample_cb sample, void
 		sample(key, hsample.upper_90, opaque);
 	}
 
+	WITH_SUFFIX(".upper_99") {
+		sample(key, hsample.upper_99, opaque);
+	}
+
 	WITH_SUFFIX(".sum") {
 		sample(key, hsample.sum, opaque);
 	}

tests/histogram.c

@@ -60,6 +60,7 @@ void test_histogram__single_element(void)
 	sput_fail_unless(sample.lower == 42.0, "sample.lower");
 	sput_fail_unless(sample.upper == 42.0, "sample.upper");
 	sput_fail_unless(sample.upper_90 == 42.0, "sample.upper_90");
+	sput_fail_unless(sample.upper_99 == 42.0, "sample.upper_99");
 	sput_fail_unless(sample.mean == 42.0, "sample.mean");
 	sput_fail_unless(sample.mean_90 == 42.0, "sample.mean_90");
 	sput_fail_unless(sample.count == 1, "sample.count");
@@ -96,27 +97,26 @@ void test_histogram__multisamples(void)
 
 	memset(&h, 0x0, sizeof(h));
 
-	for (i = 0; i < 8; ++i) {
-		for (j = 0; j < 128; ++j)
-			brubeck_histo_push(&h, (double)(j + 1), 1.0);
-
-		sput_fail_unless(h.size == 128, "histogram size");
-		sput_fail_unless(h.count == 128, "histogram value count");
-
-		brubeck_histo_sample(&sample, &h);
-
-		sput_fail_unless(sample.lower == 1.0, "sample.lower");
-		sput_fail_unless(sample.upper == 128.0, "sample.upper");
-		sput_fail_unless(sample.upper_90 == 115.0, "sample.upper_90");
-		sput_fail_unless(sample.mean == 64.5, "sample.mean");
-		sput_fail_unless(sample.mean_90 == 58.0, "sample.mean_90");
-		sput_fail_unless(sample.count == 128, "sample.count");
-		sput_fail_unless(sample.count_90 == 115, "sample.count_90");
-		sput_fail_unless(sample.sum == 8256.0, "sample.sum");
-		sput_fail_unless(sample.sum_90 == 6670, "sample.sum_90");
-		sput_fail_unless(floor(sample.std) == 36.0, "sample.std");
-		sput_fail_unless(sample.median == 64.0, "sample.median");
-	}
+	for (j = 0; j < 128; ++j)
+		brubeck_histo_push(&h, (double)(j + 1), 1.0);
+
+	sput_fail_unless(h.size == 128, "histogram size");
+	sput_fail_unless(h.count == 128, "histogram value count");
+
+	brubeck_histo_sample(&sample, &h);
+
+	sput_fail_unless(sample.lower == 1.0, "sample.lower");
+	sput_fail_unless(sample.upper == 128.0, "sample.upper");
+	sput_fail_unless(sample.upper_90 == 115.0, "sample.upper_90");
+	sput_fail_unless(sample.upper_99 == 127.0, "sample.upper_99");
+	sput_fail_unless(sample.mean == 64.5, "sample.mean");
+	sput_fail_unless(sample.mean_90 == 58.0, "sample.mean_90");
+	sput_fail_unless(sample.count == 128, "sample.count");
+	sput_fail_unless(sample.count_90 == 115, "sample.count_90");
+	sput_fail_unless(sample.sum == 8256.0, "sample.sum");
+	sput_fail_unless(sample.sum_90 == 6670, "sample.sum_90");
+	sput_fail_unless(floor(sample.std) == 36.0, "sample.std");
+	sput_fail_unless(sample.median == 64.0, "sample.median");	
 }
 
 void test_histogram__with_sample_rate(void)
@@ -138,6 +138,7 @@ void test_histogram__with_sample_rate(void)
 	sput_fail_unless(sample.lower == 1.0, "sample.lower");
 	sput_fail_unless(sample.upper == 128.0, "sample.upper");
 	sput_fail_unless(sample.upper_90 == 115.0, "sample.upper_90");
+	sput_fail_unless(sample.upper_99 == 127.0, "sample.upper_99");
 	sput_fail_unless(sample.mean == 64.5, "sample.mean");
 	sput_fail_unless(floor(sample.mean_90) == 57.0, "sample.mean_90");
 	sput_fail_unless(sample.count == 1280, "sample.count");