implicit declaration of function is invalid in C99 - MacOS x86

[meow464]

Solution

It was entirely my fault. I was running the commands from the wrong directory, this flang instead of the fork with macos support.

Following the build instructions on step 3 (flang/runtime/libpgmath) I get an error.

Environment

macOS Big Sur x86_64
Apple clang version 12.0.5 (clang-1205.0.22.11)
clang 10.0 when using classic-flang-llvm-project

INSTALL_PREFIX=/usr/local

CMAKE_OPTIONS="-DCMAKE_INSTALL_PREFIX=$INSTALL_PREFIX -DLLVM_CONFIG=$INSTALL_PREFIX/bin/llvm-config \
-DCMAKE_CXX_COMPILER=$INSTALL_PREFIX/bin/clang++ -DCMAKE_C_COMPILER=$INSTALL_PREFIX/bin/clang \
-DCMAKE_Fortran_COMPILER=$INSTALL_PREFIX/bin/flang -DCMAKE_Fortran_COMPILER_ID=Flang \
-DLLVM_TARGETS_TO_BUILD=X86"

What I tried

cmake $CMAKE_OPTIONS .. # here it uses classic-flang-llvm-project under /usr/local
cmake $CMAKE_OPTIONS -DCMAKE_C_COMPILER=/usr/bin/gcc -DCMAKE_CXX_COMPILER=/usr/bin/g++ ..
cmake $CMAKE_OPTIONS -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ ..

Reverting this commit

The error

But after make I get:

[ 30%] Building C object lib/common/CMakeFiles/common.dir/fpcvt.c.o
/Users/tuco/Projects/flang/flang/runtime/libpgmath/lib/common/fpcvt.c:421:5: error: implicit declaration of function '__io_set_errno' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    __io_set_errno(ERANGE);
    ^
/Users/tuco/Projects/flang/flang/runtime/libpgmath/lib/common/fpcvt.c:427:5: error: implicit declaration of function '__io_set_errno' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    __io_set_errno(ERANGE);
    ^
/Users/tuco/Projects/flang/flang/runtime/libpgmath/lib/common/fpcvt.c:432:7: error: implicit declaration of function '__io_set_errno' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      __io_set_errno(ERANGE);

[meow464]

Adding #include "../../../include/stdioInterf.h" to runtime/libpgmath/lib/common/fpcvt.c leads to

[ 99%] Built target x86_64_pow_fma3
[ 99%] Building C object lib/x86_64/powi/CMakeFiles/x86_64_powi.dir/powi_128.c.o
[ 99%] Building C object lib/x86_64/powi/CMakeFiles/x86_64_powi.dir/powi_256.c.o
[ 99%] Built target x86_64_powi
[100%] Linking CXX shared library libpgmath.dylib
Undefined symbols for architecture x86_64:
  "___mth_i_dceil", referenced from:
      _mth_intrins_defs in dispatch.c.o
      _fptr2name in dispatch.c.o
     (maybe you meant: ___mth_i_dceil_sse)
  "___mth_i_dfloor", referenced from:
      _mth_intrins_defs in dispatch.c.o
      _fptr2name in dispatch.c.o
     (maybe you meant: ___mth_i_dfloor_sse)
  "___mth_i_floor", referenced from:
      _mth_intrins_defs in dispatch.c.o
      _fptr2name in dispatch.c.o
     (maybe you meant: ___mth_i_floor_sse)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/libpgmath.dylib] Error 1
make[1]: *** [lib/CMakeFiles/pgmath.dir/all] Error 2
make: *** [all] Error 2

[meow464]

I just noticed that in the cmake step it prints:

-- LIBPGMATH: Cannot find llvm-lit.                                                                                                                                                                                  
-- LIBPGMATH: Please put llvm-lit in your PATH, set LIBPGMATH_LLVM_LIT_EXECUTABLE to its full path or point LIBPGMATH_LLVM_TOOLS_DIR to its directory                                                                
CMake Warning at cmake/modules/LibmathUtils.cmake:8 (message):                                                                                                                                                       
  LIBPGMATH: The check-libpgmath target will not be available!                                                                                                                                                       
Call Stack (most recent call first):                                                                                                                                                                                 
  test/CMakeLists.txt:51 (libpgmath_warning_say)

EDIT1:

This did not work: LIBPGMATH_LLVM_LIT_EXECUTABLE="/Users/tuco/Projects/flang/classic-flang-llvm-project/build/bin/llvm-lit"

EDIT2:

Silly me, it was a cmake flag, not an environment variable. Unfortunately I still get the linker error from the first post.

cmake $CMAKE_OPTIONS -DLIBPGMATH_LLVM_LIT_EXECUTABLE="/Users/tuco/Projects/flang/classic-flang-llvm-project/build/bin/llvm-lit" ..

[isuruf]

You need the changes in #1120 for macos