miner: fix pointer reuse that was resulting in incorrect eff gas price calc

bsh98 · bsh98 · commit 660deaa241b2 · 2023-02-07T11:54:58.000-08:00
diff --git a/miner/worker.go b/miner/worker.go
@@ -1870,7 +1870,7 @@ func (w *worker) computeBundleGas(env *environment, bundle types.MevBundle, stat
 		if err != nil {
 			return simulatedBundle{}, err
 		}
-		gasFeesTx := gasUsed.Mul(gasUsed, gasPrice)
+		gasFeesTx := new(big.Int).Mul(gasUsed, gasPrice)
 		coinbaseBalanceAfter := state.GetBalance(env.coinbase)
 		coinbaseDelta := big.NewInt(0).Sub(coinbaseBalanceAfter, coinbaseBalanceBefore)
 		coinbaseDelta.Sub(coinbaseDelta, gasFeesTx)

Original file line number	Diff line number	Diff line change
`@@ -1870,7 +1870,7 @@ func (w worker) computeBundleGas(env environment, bundle types.MevBundle, stat`
`1870`	`1870`	`if err != nil {`
`1871`	`1871`	`return simulatedBundle{}, err`
`1872`	`1872`	`}`
`1873`		`- gasFeesTx := gasUsed.Mul(gasUsed, gasPrice)`
	`1873`	`+ gasFeesTx := new(big.Int).Mul(gasUsed, gasPrice)`
`1874`	`1874`	`coinbaseBalanceAfter := state.GetBalance(env.coinbase)`
`1875`	`1875`	`coinbaseDelta := big.NewInt(0).Sub(coinbaseBalanceAfter, coinbaseBalanceBefore)`
`1876`	`1876`	`coinbaseDelta.Sub(coinbaseDelta, gasFeesTx)`