fix proper overflow handling

TymKh · TymKh · commit c7deb75281cb · 2024-02-07T17:18:53.000+01:00
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -2383,8 +2383,8 @@ func (s *BundleAPI) CallBundle(ctx context.Context, args CallBundleArgs) (map[st
 		if err != nil {
 			return nil, fmt.Errorf("err: %w; txhash %s", err, tx.Hash())
 		}
-		uint256GasPrice, ok := uint256.FromBig(gasPrice)
-		if !ok {
+		uint256GasPrice, overflow := uint256.FromBig(gasPrice)
+		if overflow {
 			return nil, fmt.Errorf("incorrect gasPrice txhash %s", tx.Hash())
 		}
 		gasFeesTx := new(uint256.Int).Mul(uint256.NewInt(receipt.GasUsed), uint256GasPrice)

Original file line number	Diff line number	Diff line change
`@@ -2383,8 +2383,8 @@ func (s *BundleAPI) CallBundle(ctx context.Context, args CallBundleArgs) (map[st`
`2383`	`2383`	`if err != nil {`
`2384`	`2384`	`return nil, fmt.Errorf("err: %w; txhash %s", err, tx.Hash())`
`2385`	`2385`	`}`
`2386`		`- uint256GasPrice, ok := uint256.FromBig(gasPrice)`
`2387`		`- if !ok {`
	`2386`	`+ uint256GasPrice, overflow := uint256.FromBig(gasPrice)`
	`2387`	`+ if overflow {`
`2388`	`2388`	`return nil, fmt.Errorf("incorrect gasPrice txhash %s", tx.Hash())`
`2389`	`2389`	`}`
`2390`	`2390`	`gasFeesTx := new(uint256.Int).Mul(uint256.NewInt(receipt.GasUsed), uint256GasPrice)`