fix arguments validation. (#20)

Author: flask-pro

CHANGES.md

@@ -1,3 +1,13 @@
+## Version 0.12.1
+
+* Fix arguments validation.
+
+* ## Version 0.12.0
+
+* Validating and serializing arguments from `request.view_args` to `request.first_view_args`.
+* Validating and serializing arguments from `request.args` to `request.first_args`.
+* Validating and serializing arguments from `request.cookies` to `request.first_cookies`.
+
 ## Version 0.11.0
 
 * Add using marshmallow schemas for validation and serialization data.

src/flask_first/__init__.py

@@ -30,7 +30,7 @@
 from .schema.tools import convert_schemas
 from .schema.tools import resolving_refs
 
-__version__ = '0.12.0'
+__version__ = '0.12.1'
 
 
 class First:
@@ -136,10 +136,14 @@ def _resolved_params(self, payload: MultiDict) -> dict:
 
     def _arg_to_list(self, args: dict, schema_fields: dict) -> dict:
         for arg in args:
-            if isinstance(schema_fields[arg], marshmallow.fields.List) and not isinstance(
-                args[arg], list
-            ):
+            arg_value = schema_fields.get(arg, ...)
+
+            if arg_value is ...:
+                continue
+
+            if isinstance(arg_value, marshmallow.fields.List) and not isinstance(args[arg], list):
                 args[arg] = [args[arg]]
+
         return args
 
     def _registration_swagger_ui_blueprint(self, swagger_ui_path: str | Path) -> None:

tests/specs/v3.0/args.openapi.yaml

@@ -0,0 +1,50 @@
+openapi: 3.0.3
+info:
+  title: Mini API for testing Flask-First
+  version: 1.0.0
+paths:
+  /parameters_endpoint:
+    parameters:
+      - name: exist_arg
+        in: query
+        schema:
+          type: string
+    get:
+      operationId: mini_endpoint
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  non_exist_arg:
+                    type: string
+        "400":
+          description: Bad Request
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/ERROR"
+components:
+  schemas:
+    ERROR:
+      type: object
+      required:
+        - code
+        - name
+        - description
+      additionalProperties: false
+      properties:
+        code:
+          type: integer
+          minimum: 400
+          maximum: 599
+          example: 400
+        name:
+          type: string
+          example: "Bad Request"
+        description:
+          type: string
+          example: "Request data not valid."

tests/test_args.py

@@ -0,0 +1,35 @@
+from pathlib import Path
+
+from flask import Flask
+from flask import request
+from flask_first import First
+
+from .conftest import BASEDIR
+
+
+def test_specification__non_exist_args():
+    def mini_endpoint() -> dict:
+        args = request.first_args
+        assert args.get('non_exist_arg') is None
+
+        return {'non_exist_arg': None}
+
+    first = First(Path(BASEDIR, 'specs/v3.0/args.openapi.yaml'))
+
+    def create_app():
+        app = Flask('non_exist_args')
+        app.debug = 1
+        app.testing = 1
+        app.config['FIRST_RESPONSE_VALIDATION'] = True
+        first.init_app(app)
+        first.add_view_func(mini_endpoint)
+        return app
+
+    app = create_app()
+
+    with app.test_client() as test_client:
+        r = test_client.get(
+            '/parameters_endpoint',
+            query_string={'non_exist_arg': 'NON_EXIST_ARGS'},
+        )
+        assert r.status_code == 400