chore: sync Base Sepolia v2 addresses to v2.4 deployment#14
Open
MrTalecky wants to merge 1 commit into
Open
Conversation
Base Sepolia v2 addresses in `deployments/base-sepolia.json` and `packages/sdk/src/deployments.ts` were stale from the 2026-02-19 v2 deploy. They never captured the v2.4 redeploy at block 38314732 (2026-03-02, VaultV2 depositFor + setTreasury for Trial Market Program) or the DepositRouter deployment. - `deployments/base-sepolia.json`: replace all 8 v2 contract addresses with canonical v2.4 addresses, add `depositRouter`, bump deployBlock to 38314732. - `deployments/base-mainnet.json`: add `feeCollector` field (LmsrFeeCollector was deployed post-launch but never added here). - `packages/sdk/src/deployments.ts`: mirror JSON changes; add optional `feeCollector?` to `DeploymentsV2` interface (optional until deployed per chain — Sepolia does not yet have one). Canonical source for the new addresses: `flipcoin-app/src/features/dev-amm/contracts/deployments.local.ts` (deploymentsBaseSepoliaV2 / deploymentsBaseMainnetV2). Verified: 824 SDK tests pass, forge build clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
MrTalecky
force-pushed
the
chore/sync-base-sepolia-deployments
branch
from
c47bcaf to
398a495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployments/base-sepolia.jsonandpackages/sdk/src/deployments.tswere stale from the original 2026-02-19 v2 deploy. They never captured the v2.4 redeploy at block 38314732 (2026-03-02, VaultV2depositFor+setTreasuryfor Trial Market Program) or theDepositRouterdeployment.deployments/base-sepolia.json: replace all 8 v2 contract addresses with canonical v2.4 addresses, adddepositRouter, bumpdeployBlockto 38314732.deployments/base-mainnet.json: addfeeCollectorfield (LmsrFeeCollector was deployed post-launch but never recorded here).packages/sdk/src/deployments.ts: mirror JSON changes; add optionalfeeCollector?toDeploymentsV2interface (optional until deployed per chain — Sepolia does not yet have one).Source of truth
flipcoin-app/src/features/dev-amm/contracts/deployments.local.ts—deploymentsBaseSepoliaV2/deploymentsBaseMainnetV2. These are the addresses the production app and agent API use today.Test plan
npm testinpackages/sdk— 824 / 824 passingforge build— clean (only pre-existing style warnings)feeCollectormatches app mainnet deployment (0x12a20Aa075277391b18e97b64FAc1e12980e10d3)