New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use polymorphism to abstract over different MR/PR/whatever sources #1

Open

nikolaykasyanov opened this issue Mar 20, 2017 · 0 comments

Contributor

nikolaykasyanov commented Mar 20, 2017

At the moment we're explicitly checking source type twice: to get the diff and to get proper diff delimiter format.

This can be hidden nicely behind some interface with 3 (for example) implementations: for GitLab, GitHub and BitBucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment