bugfix: false positive on expressions containing Count

Meir017 · Meir017 · commit 50491484f9cc · 2024-10-07T22:46:17.000+03:00
diff --git a/src/FluentAssertions.Analyzers/Tips/FluentAssertionsAnalyzer.cs b/src/FluentAssertions.Analyzers/Tips/FluentAssertionsAnalyzer.cs
@@ -334,7 +334,8 @@ private static void AnalyzeInvocation(OperationAnalysisContext context, FluentAs
 
                         }
                     }
-                    if (invocation.TryGetFirstDescendent<IPropertyReferenceOperation>(out var propertyBeforeShould))
+                    var argument = invocation.Arguments[0].Value.UnwrapConversion();
+                    if (argument is IPropertyReferenceOperation propertyBeforeShould)
                     {
                         switch (propertyBeforeShould.Property.Name)
                         {

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,8 @@ private static void AnalyzeInvocation(OperationAnalysisContext context, FluentAs`
`334`	`334`
`335`	`335`	`}`
`336`	`336`	`}`
`337`		`- if (invocation.TryGetFirstDescendent<IPropertyReferenceOperation>(out var propertyBeforeShould))`
	`337`	`+ var argument = invocation.Arguments[0].Value.UnwrapConversion();`
	`338`	`+ if (argument is IPropertyReferenceOperation propertyBeforeShould)`
`338`	`339`	`{`
`339`	`340`	`switch (propertyBeforeShould.Property.Name)`
`340`	`341`	`{`