Skip to content

Checklist of all tips and whether they have analyzers #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arithmomaniac opened this issue Dec 27, 2023 · 4 comments · Fixed by #307
Closed

Checklist of all tips and whether they have analyzers #274

Arithmomaniac opened this issue Dec 27, 2023 · 4 comments · Fixed by #307
Labels

Comments

@Arithmomaniac
Copy link

Instead of tracking https://fluentassertions.com/tips/#improved-assertions piecemeal (e.g. #245) there should be an issue checklist in this repo with a here, with each suggested improvement listed as a task.

@Arithmomaniac
Copy link
Author

If it is preferred to link to each analyzer when it exists on the "tips" page instead, I can create an issue in the main repo

@Meir017 Meir017 added the idea label Dec 27, 2023
@Meir017
Copy link
Member

Meir017 commented Dec 29, 2023

Instead of tracking https://fluentassertions.com/tips/#improved-assertions piecemeal (e.g. #245) there should be an issue checklist in this repo with a here, with each suggested improvement listed as a task.

I was thinking of having a test project with test-cases for all of the different tips, it will serve as documentation and an integration test that runs dotnet format

@Meir017
Copy link
Member

Meir017 commented Feb 29, 2024

@Arithmomaniac I was thinking of something like this -
image

https://github.com/fluentassertions/fluentassertions.analyzers/pull/307/files#diff-40f9cb87232fc6df6199d10de09342f50ff38d1f153bfa1c77e8b62e878494f8

this way the asserts are evaluated in the CI to make sure the old/new asserts have the same result

@Arithmomaniac
Copy link
Author

@Meir017 I love it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants