Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between query/txn opts and external opts #840

Open
JaceRockman opened this issue Jul 17, 2024 · 0 comments
Open

Distinguish between query/txn opts and external opts #840

JaceRockman opened this issue Jul 17, 2024 · 0 comments

Comments

@JaceRockman
Copy link
Contributor

Currently, we call both of them opts but they are used for different purposes and so we should update the naming of them to reflect this in some way. My initial thought was to keep the query/txn opts as opts but then use request-opts for the other one, but @dpetran pointed out that it's not necessarily the case that these functions will be called via a request. My next thought was a more generic name of external-opts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant