Skip to content

Design flaws #14

@subzero911

Description

@subzero911

I don't like the design of Command in general.
It's similar to ObservableFuture from MobX, but instead of solid enum states (initial, running, success, failure) it has a boolean isRunning. That can potentially lead to a state inconsistency (isRunning == true but has data / errors at the same time).
Running and success/failure states should be mutually exclusive.

** Proposal **
Replace isRunning to a status enum.

Also, there's no widget like Observer or Selector.
I have to create a new widget each time and inherit from WatchingWidget.
I cannot wrap a piece of code into a Selector-like widget and subscribe it to a reactive value. Correct me if I'm wrong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions