Skip to content

Use separate log for FlutterCommand #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jul 16, 2025

I added an option (default off) to record full file paths in logs. Originally I was thinking that we shouldn't record any file paths, but it seems reasonable to have them sometimes for debugging setup issues since these are recorded on a user's machine rather than to somewhere centralized that we receive by default.

@helin24 helin24 marked this pull request as ready for review July 16, 2025 20:38
@helin24 helin24 requested review from jwren and pq July 16, 2025 20:38
@helin24 helin24 merged commit 5631957 into flutter:master Jul 17, 2025
8 checks passed
@helin24 helin24 deleted the command-log branch July 17, 2025 15:59
@pq
Copy link
Contributor

pq commented Jul 21, 2025

Cool! I wonder if this is something we should run by @anderdobo or @mit-mit? Do we need any extra messaging to make sure folks know not to have this enabled if filenames are sensitive and they're sharing logs with us?

@helin24
Copy link
Member Author

helin24 commented Jul 21, 2025

Before this change we were logging these paths in idea.log, so this change is moving towards less sharing of filenames. I'm thinking for now we can mention if we're asking for logs, but in the future if we start attaching a log file to issues, we should do a check for the state of the setting.

@helin24
Copy link
Member Author

helin24 commented Jul 21, 2025

But regardless, if any of you have opinions of what we can/should log in local files, please let me know. I started a doc on this but don't have much content at the moment.

@pq
Copy link
Contributor

pq commented Jul 21, 2025

SGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants