Skip to content

Commit dbaf8bf

Browse files
authored
Merge pull request #405 from darkowlzz/client-objectkeyfromobject
Use ObjectKeyFromObject instead of ObjectKey
2 parents 40a4767 + 9825a60 commit dbaf8bf

File tree

2 files changed

+3
-34
lines changed

2 files changed

+3
-34
lines changed

controllers/helmchart_controller.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ import (
6161

6262
sourcev1 "github.com/fluxcd/source-controller/api/v1beta1"
6363
"github.com/fluxcd/source-controller/internal/helm"
64-
"github.com/fluxcd/source-controller/internal/util"
6564
)
6665

6766
// +kubebuilder:rbac:groups=source.toolkit.fluxcd.io,resources=helmcharts,verbs=get;list;watch;create;update;patch;delete
@@ -926,7 +925,7 @@ func (r *HelmChartReconciler) requestsForHelmRepositoryChange(o client.Object) [
926925
// enqueued twice.
927926
var reqs []reconcile.Request
928927
for _, i := range list.Items {
929-
reqs = append(reqs, reconcile.Request{NamespacedName: util.ObjectKey(&i)})
928+
reqs = append(reqs, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&i)})
930929
}
931930
return reqs
932931
}
@@ -955,7 +954,7 @@ func (r *HelmChartReconciler) requestsForGitRepositoryChange(o client.Object) []
955954
// enqueued twice.
956955
var reqs []reconcile.Request
957956
for _, i := range list.Items {
958-
reqs = append(reqs, reconcile.Request{NamespacedName: util.ObjectKey(&i)})
957+
reqs = append(reqs, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&i)})
959958
}
960959
return reqs
961960
}
@@ -984,7 +983,7 @@ func (r *HelmChartReconciler) requestsForBucketChange(o client.Object) []reconci
984983
// enqueued twice.
985984
var reqs []reconcile.Request
986985
for _, i := range list.Items {
987-
reqs = append(reqs, reconcile.Request{NamespacedName: util.ObjectKey(&i)})
986+
reqs = append(reqs, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&i)})
988987
}
989988
return reqs
990989
}

internal/util/util.go

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)