-
-
Notifications
You must be signed in to change notification settings - Fork 353
Add support for ListObjectsV2 #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Similar here, we likely either overlooked it or it was added later. I'd certainly welcome a PR to add it if you have the time and inclination, and I'm certainly happy to support that however I can. |
Here is a quick idea on how ListObjectsV2 support can be added while maintaining V1 compatibility: I will add: Then we will be able to use it like:
Optionally, we can add an option, Is this fine? |
@Ankk98 hmm, something along those lines sounds reasonable. Could you summarize the differences between v1 and v2, if you know them? I looked at the doc you linked, but it wasn't immediately obvious to me. Depending on how it has changed, it might make sense to make v2 the default for models, but I was having a hard time figuring out what was different. |
Key Differences1. Pagination
2. Response Structure
3. PerformanceListObjectsV2
AWS recommends to use v2 API as default. |
…eprecating bare days parameter usage fog#741
Thanks for the updates, I think on reflection that your approach sounds like a good one. I was debating whether we should instead have v2 be the new default for models and allow opting back into v1, but I worry that could inadvertently lead to breakage for people. So this is probably safer for now. |
Yeah, I think a 2 step approach will be good. If this sounds good to you, I can send a pr. |
@Ankk98 Sure, sounds good to me, thanks! |
The text was updated successfully, but these errors were encountered: