Enhance server model to be able to detach more than one managed disk

Author: KevinLoiseau

lib/fog/azurerm/models/compute/server.rb

@@ -178,8 +178,13 @@ def attach_managed_disk(disk_name, disk_resource_group, async = false)
           async ? create_fog_async_response(response) : merge_attributes(Fog::Compute::AzureRM::Server.parse(response))
         end
 
+        # kept for backward compatibility
         def detach_managed_disk(disk_name, async = false)
-          response = service.detach_data_disk_from_vm(resource_group, name, disk_name, async)
+          detach_managed_disks(disk_name, async)
+        end
+
+        def detach_managed_disks(disk_names, async = false)
+          response = service.detach_data_disk_from_vm(resource_group, name, disk_names, async)
           async ? create_fog_async_response(response) : merge_attributes(Fog::Compute::AzureRM::Server.parse(response))
         end
 

test/models/compute/test_server.rb

@@ -234,4 +234,16 @@ def test_detach_managed_disk_response
       assert_instance_of Fog::AzureRM::AsyncResponse, @server.detach_managed_disk('managed_disk_name', true)
     end
   end
+
+  def test_detach_managed_disks_response
+    response = ApiStub::Models::Compute::Server.create_linux_virtual_machine_response(@compute_client)
+    @service.stub :detach_data_disk_from_vm, response do
+      assert_instance_of Fog::Compute::AzureRM::Server, @server.detach_managed_disks(%w(managed_disk_name1 managed_disk_name2))
+    end
+
+    async_response = Concurrent::Promise.execute { 10 }
+    @service.stub :detach_data_disk_from_vm, async_response do
+      assert_instance_of Fog::AzureRM::AsyncResponse, @server.detach_managed_disks(%w(managed_disk_name1 managed_disk_name2), true)
+    end
+  end
 end