Puppeteer tests: change index load waitUntil from networkidle0 to domcontentloaded (#3170)

* Puppeteer tests: change index load waitUntil from networkidle0 to domcontentloaded

* Add julia cache action

* Also await the main menu to be ready

Author: fonsp

.github/workflows/FrontendTest.yml

@@ -30,6 +30,8 @@ jobs:
               with:
                   version: "1.10" # our lowest supported version
 
+            - uses: julia-actions/cache@v2
+
             - name: Install Pluto.jl packages
               run: |
                   julia --project=$GITHUB_WORKSPACE -e "using Pkg; Pkg.instantiate()"

test/frontend/__tests__/autocomplete_test.js

@@ -8,6 +8,7 @@ import {
     writeSingleLineInPlutoInput,
     shutdownCurrentNotebook,
     setupPlutoBrowser,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("PlutoAutocomplete", () => {
@@ -25,7 +26,7 @@ describe("PlutoAutocomplete", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
     })
     afterEach(async () => {
         await saveScreenshot(page)

test/frontend/__tests__/bonds.js

@@ -3,6 +3,7 @@ import { saveScreenshot, createPage, paste, waitForContentToBecome, waitForConte
 import {
     createNewNotebook,
     getPlutoUrl,
+    gotoPlutoMainMenu,
     importNotebook,
     runAllChanged,
     setupPlutoBrowser,
@@ -27,7 +28,7 @@ describe("@bind", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
     })
     afterEach(async () => {
         await saveScreenshot(page)

test/frontend/__tests__/import_notebook_test.js

@@ -10,6 +10,7 @@ import {
     shutdownCurrentNotebook,
     setupPlutoBrowser,
     runAllChanged,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("PlutoImportNotebook", () => {
@@ -27,7 +28,7 @@ describe("PlutoImportNotebook", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
     })
     afterEach(async () => {
         await saveScreenshot(page)

test/frontend/__tests__/javascript_api.js

@@ -8,6 +8,7 @@ import {
     setupPlutoBrowser,
     waitForPlutoToCalmDown,
     runAllChanged,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("JavaScript API", () => {
@@ -25,7 +26,7 @@ describe("JavaScript API", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
         await createNewNotebook(page)
     })
     afterEach(async () => {

test/frontend/__tests__/new_notebook_test.js

@@ -13,6 +13,7 @@ import {
     manuallyEnterCells,
     runAllChanged,
     clearPlutoInput,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("PlutoNewNotebook", () => {
@@ -30,7 +31,7 @@ describe("PlutoNewNotebook", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
         await createNewNotebook(page)
     })
     afterEach(async () => {

test/frontend/__tests__/paste_test.disabled

@@ -31,7 +31,7 @@ describe("Paste Functionality", () => {
     })
 
     beforeEach(async () => {
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
         await createNewNotebook(page)
         await page.waitForSelector("pluto-input", { visible: true })
     })

test/frontend/__tests__/published_to_js.js

@@ -1,6 +1,6 @@
 import puppeteer from "puppeteer"
 import { saveScreenshot, createPage } from "../helpers/common"
-import { importNotebook, getPlutoUrl, shutdownCurrentNotebook, setupPlutoBrowser } from "../helpers/pluto"
+import { importNotebook, getPlutoUrl, shutdownCurrentNotebook, setupPlutoBrowser, gotoPlutoMainMenu } from "../helpers/pluto"
 
 describe("published_to_js", () => {
     /**
@@ -17,7 +17,7 @@ describe("published_to_js", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
     })
     afterEach(async () => {
         await saveScreenshot(page)

test/frontend/__tests__/safe_preview.js

@@ -13,6 +13,7 @@ import {
     runAllChanged,
     openPathOrURLNotebook,
     getAllCellOutputs,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("safe_preview", () => {
@@ -30,7 +31,7 @@ describe("safe_preview", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
     })
     afterEach(async () => {
         await saveScreenshot(page)
@@ -128,7 +129,7 @@ Hello
         let path = await page.evaluate(() => window.editor_state.notebook.path.replaceAll("\\", "\\\\"))
         let shutdown = async () => {
             await shutdownCurrentNotebook(page)
-            await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+            await gotoPlutoMainMenu(page)
             // Wait for it to be shut down
             await page.waitForSelector(`li.recent a[title="${path}"]`)
         }

test/frontend/__tests__/slide_controls.js

@@ -4,6 +4,7 @@ import {
     createNewNotebook,
     getCellIds,
     getPlutoUrl,
+    gotoPlutoMainMenu,
     importNotebook,
     manuallyEnterCells,
     runAllChanged,
@@ -28,7 +29,7 @@ describe("slideControls", () => {
     })
     beforeEach(async () => {
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
     })
     afterEach(async () => {
         await saveScreenshot(page)

test/frontend/__tests__/wind_directions.js

@@ -9,6 +9,7 @@ import {
     waitForPlutoToCalmDown,
     runAllChanged,
     importNotebook,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("wind_directions", () => {
@@ -24,7 +25,7 @@ describe("wind_directions", () => {
     beforeAll(async () => {
         browser = await setupPlutoBrowser()
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
 
         await importNotebook(page, "wind_directions.jl", { permissionToRunCode: true, timeout: 180 * 1000 })
         await page.waitForTimeout(1000)

test/frontend/__tests__/with_js_link.js

@@ -10,6 +10,7 @@ import {
     writeSingleLineInPlutoInput,
     runAllChanged,
     waitForPlutoToCalmDown,
+    gotoPlutoMainMenu,
 } from "../helpers/pluto"
 
 describe("with_js_link", () => {
@@ -25,7 +26,7 @@ describe("with_js_link", () => {
     beforeAll(async () => {
         browser = await setupPlutoBrowser()
         page = await createPage(browser)
-        await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+        await gotoPlutoMainMenu(page)
 
         await importNotebook(page, "with_js_link.jl", { timeout: 120 * 1000 })
     })

test/frontend/helpers/pluto.js

@@ -36,7 +36,7 @@ export const prewarmPluto = async (browser) => {
     let page = await createPage(browser)
 
     await browser.defaultBrowserContext().overridePermissions(getPlutoUrl(), ["clipboard-read", "clipboard-write"])
-    await page.goto(getPlutoUrl(), { waitUntil: "networkidle0" })
+    await gotoPlutoMainMenu(page)
     await createNewNotebook(page)
     const cellInputSelector = "pluto-input .cm-content"
     await page.waitForSelector(cellInputSelector, { visible: true })
@@ -73,6 +73,14 @@ export const setupPlutoBrowser = async () => {
     return browser
 }
 
+/**
+ * @param {Page} page
+ */
+export const gotoPlutoMainMenu = async (page) => {
+    await page.goto(getPlutoUrl(), { waitUntil: "domcontentloaded" })
+    await page.waitForFunction(() => document.querySelector(`.not_yet_ready`) == null)
+}
+
 /**
  * @param {Page} page
  */