chore: remove TODOs in forceignore

Author: WillieRuemmele

src/convert/replacements.ts

@@ -66,10 +66,7 @@ export const replacementIterations = async (input: string, replacements: MarkedR
   const lifecycleInstance = Lifecycle.getInstance();
   let output = input;
   for (const replacement of replacements) {
-    // TODO: node 16+ has String.replaceAll for non-regex scenarios
-    const regex =
-      typeof replacement.toReplace === 'string' ? new RegExp(replacement.toReplace, 'g') : replacement.toReplace;
-    const replaced = output.replace(regex, replacement.replaceWith ?? '');
+    const replaced = output.replaceAll(new RegExp(replacement.toReplace, 'g'), replacement.replaceWith ?? '');
 
     if (replaced !== output) {
       output = replaced;

src/resolve/forceIgnore.ts

@@ -8,7 +8,7 @@
 import { dirname, join, relative } from 'node:path';
 import ignore, { Ignore } from 'ignore/index';
 import { readFileSync } from 'graceful-fs';
-import { Lifecycle } from '@salesforce/core';
+import { Lifecycle, Logger } from '@salesforce/core';
 import { SourcePath } from '../common/types';
 import { searchUp } from '../utils/fileSystemHandler';
 
@@ -42,7 +42,7 @@ export class ForceIgnore {
         this.forceIgnoreDirectory = dirname(forceIgnorePath);
       }
     } catch (e) {
-      // TODO: log no force ignore
+      Logger.childFromRoot(this.constructor.name).info('no .forceignore found');
     }
   }
 

test/resolve/forceIgnore.test.ts

@@ -84,30 +84,15 @@ describe('ForceIgnore', () => {
       forceIgnore = new ForceIgnore();
     });
 
-    it('Should ignore files starting with a dot', () => {
-      const dotPath = join(root, '.xyz');
-
-      expect(forceIgnore.accepts(dotPath)).to.be.false;
-      expect(forceIgnore.denies(dotPath)).to.be.true;
-    });
-
-    it('Should ignore files ending in .dup', () => {
-      const dupPath = join(root, 'abc.dup');
-
-      expect(forceIgnore.accepts(dupPath)).to.be.false;
-      expect(forceIgnore.denies(dupPath)).to.be.true;
-    });
-
-    it('Should ignore files named package2-descriptor.json', () => {
-      const descriptorPath = join(root, 'package2-descriptor.json');
-      expect(forceIgnore.accepts(descriptorPath)).to.be.false;
-      expect(forceIgnore.denies(descriptorPath)).to.be.true;
-    });
-
-    it('Should ignore files named package2-manifest.json', () => {
-      const manifestPath = join(root, 'package2-manifest.json');
-      expect(forceIgnore.accepts(manifestPath)).to.be.false;
-      expect(forceIgnore.denies(manifestPath)).to.be.true;
+    // the example's index here is specific to the rules order in ForceIgnore.DEFAULT_IGNORE
+    const forceIgnoreExamples = ['abc.dup', '.xyz', 'package2-descriptor.json', 'package2-manifest.json'];
+    forceIgnoreExamples.map((ignore) => {
+      it(`Should ignore files starting with a ${ignore}`, () => {
+        const testPath = join(root, ignore);
+
+        expect(forceIgnore.accepts(testPath)).to.be.false;
+        expect(forceIgnore.denies(testPath)).to.be.true;
+      });
     });
 
     it('Should allow .forceignore file to override defaults', () => {