feat: explicitly set projectDir on componentSet to prevent use of cwd

* feat: explicitly set projectDir on componentSet to prevent use of cwd

* chore: auto-update metadata coverage in METADATA_SUPPORT.md

* chore: set non-latest dist tag

* test: record perf

* chore: get dist tag right

* chore(release): 7.14.0-beta.1 [skip ci]

* chore(release): 7.14.0-beta.2 [skip ci]

* fix: restore the projectDir pass-around

* chore(release): 7.14.0-beta.3 [skip ci]

* chore: set version for release

---------

Co-authored-by: svc-cli-bot <[email protected]>

Author: mshanemc

CHANGELOG.md

@@ -187,4 +187,4 @@
       "output": []
     }
   }
-}
+}

package.json

@@ -64,6 +64,11 @@ export class ComponentSet extends LazyCollection<MetadataComponent> {
    * This is used as the value for the `version` field in the manifest.
    */
   public sourceApiVersion: string;
+  /**
+   * Used to explicitly set the project directory for the component set.
+   * When not present, sfdx-core's SfProject will use the current working directory.
+   */
+  public projectDirectory?: string;
   public fullName?: string;
   public forceIgnoredPaths?: Set<string>;
   private logger: Logger;

src/collections/componentSet.ts

@@ -120,7 +120,7 @@ export class MetadataConverter {
       const conversionPipeline = pipeline(
         Readable.from(components),
         !targetFormatIsSource && (process.env.SF_APPLY_REPLACEMENTS_ON_CONVERT === 'true' || output.type === 'zip')
-          ? (await getReplacementMarkingStream()) ?? new PassThrough({ objectMode: true })
+          ? (await getReplacementMarkingStream(cs.projectDirectory)) ?? new PassThrough({ objectMode: true })
           : new PassThrough({ objectMode: true }),
         new ComponentConverter(targetFormat, this.registry, mergeSet, defaultDirectory),
         writer

src/convert/metadataConverter.ts

@@ -81,9 +81,11 @@ export const replacementIterations = async (input: string, replacements: MarkedR
 /**
  * Reads the project, gets replacements, removes any that aren't applicable due to environment conditionals, and returns an instance of the ReplacementMarkingStream
  */
-export const getReplacementMarkingStream = async (): Promise<ReplacementMarkingStream | undefined> => {
+export const getReplacementMarkingStream = async (
+  projectDir?: string
+): Promise<ReplacementMarkingStream | undefined> => {
   // remove any that don't agree with current env
-  const filteredReplacements = envFilter(await readReplacementsFromProject());
+  const filteredReplacements = envFilter(await readReplacementsFromProject(projectDir));
   if (filteredReplacements.length) {
     return new ReplacementMarkingStream(filteredReplacements);
   }
@@ -207,8 +209,8 @@ const getEnvValue = (env: string): string => {
 /**
  * Read the `replacement` property from sfdx-project.json
  */
-const readReplacementsFromProject = async (): Promise<ReplacementConfig[]> => {
-  const proj = await SfProject.resolve();
+const readReplacementsFromProject = async (projectDir?: string): Promise<ReplacementConfig[]> => {
+  const proj = await SfProject.resolve(projectDir);
   const projJson = (await proj.resolveProjectConfig()) as { replacements?: ReplacementConfig[] };
   return projJson.replacements;
 };

src/convert/replacements.ts

@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 201.25295900000492
+    "duration": 207.436284000054
   },
   {
     "name": "sourceToMdapi",
-    "duration": 6621.193925000029
+    "duration": 5423.031130000018
   },
   {
     "name": "sourceToZip",
-    "duration": 4725.25216600002
+    "duration": 5202.063126999885
   },
   {
     "name": "mdapiToSource",
-    "duration": 3624.5386980000185
+    "duration": 3417.4116909999866
   }
 ]

test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8370C-CPU-2-80GHz/eda.json

@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 406.26530899998033
+    "duration": 444.3853680000175
   },
   {
     "name": "sourceToMdapi",
-    "duration": 8439.755018000025
+    "duration": 8262.888810999924
   },
   {
     "name": "sourceToZip",
-    "duration": 6785.0722009999445
+    "duration": 7476.526809000177
   },
   {
     "name": "mdapiToSource",
-    "duration": 4213.607210000046
+    "duration": 4032.80767800007
   }
 ]

test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8370C-CPU-2-80GHz/lotsOfClasses.json

@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 725.7692759999773
+    "duration": 707.5937909998465
   },
   {
     "name": "sourceToMdapi",
-    "duration": 11200.344226000016
+    "duration": 10896.007658000104
   },
   {
     "name": "sourceToZip",
-    "duration": 9825.344100999995
+    "duration": 9609.415148
   },
   {
     "name": "mdapiToSource",
-    "duration": 7075.819200999918
+    "duration": 6808.866952999961
   }
 ]