fix: potential undefined in SDREvent orgId

mshanemc · svc-cli-bot · web-flow · commit 82a6d2d14a8e · 2023-03-03T17:54:12.000-06:00
* fix: potential undefined in SDREvent orgId

* chore: auto-update metadata coverage in METADATA_SUPPORT.md

* chore: auto-update metadata coverage in METADATA_SUPPORT.md

* test: record perf

* test: longer time for slow windows ut

* test: record perf

* refactor: less satisfactory generic

* chore: auto-update metadata coverage in METADATA_SUPPORT.md

* test: record perf

---------

Co-authored-by: svc-cli-bot &lt;svc_cli_bot@salesforce.com&gt;
diff --git a/.mocharc.json b/.mocharc.json
@@ -6,5 +6,5 @@
   "watch-files": ["src", "test"],
   "recursive": true,
   "reporter": "spec",
-  "timeout": 5000
+  "timeout": 10000
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
diff --git a/METADATA_SUPPORT.md b/METADATA_SUPPORT.md
@@ -554,18 +554,23 @@ v58 introduces the following new types.  Here's their current level of support
 
 |Metadata Type|Support|Notes|
 |:---|:---|:---|
+|AIScoringModelDefVersion|❌|Not supported, but support could be added|
+|AIScoringModelDefinition|❌|Not supported, but support could be added|
 |Ai4mSettings|✅||
+|AssessmentConfiguration|❌|Not supported, but support could be added|
 |ClaimMgmtFoundationEnabledSettings|✅||
 |CodeBuilderSettings|✅||
 |DataWeaveResource|✅||
 |DynamicFormsSettings|✅||
+|ExperiencePropertyTypeBundle|✅||
+|FundraisingConfig|❌|Not supported, but support could be added|
 |LicensingSettings|✅||
 |OmniChannelPricingSettings|✅||
-|PaymentsBuyerAPIEnabledSettings|✅||
-|PriceSheetDefinition|❌|Not supported, but support could be added|
 |ProcessFlowMigration|❌|Not supported, but support could be added|
-|ProductSpecificationRecType|❌|Not supported, but support could be added|
+|ProductSpecificationType|❌|Not supported, but support could be added|
+|SkillType|❌|Not supported, but support could be added|
 |Web3Settings|✅||
+|WebStoreBundle|❌|Not supported, but support could be added|
 
 ## Additional Types
 
@@ -616,4 +621,3 @@ v58 introduces the following new types.  Here's their current level of support
 - InternalOrganization
 - UiViewDefinition
 - MobileSecurityPolicySet
-- ExperiencePropertyTypeBundle
diff --git a/package.json b/package.json
@@ -185,4 +185,4 @@
       "output": []
     }
   }
-}
+}
diff --git a/src/client/metadataApiDeploy.ts b/src/client/metadataApiDeploy.ts
@@ -374,8 +374,8 @@ export class MetadataApiDeploy extends MetadataTransfer<
   // eslint-disable-next-line @typescript-eslint/require-await
   protected async post(result: MetadataApiDeployStatus): Promise<DeployResult> {
     const lifecycle = Lifecycle.getInstance();
+    const connection = await this.getConnection();
     try {
-      const connection = await this.getConnection();
       const apiVersion = connection.getApiVersion();
       // Creates an array of unique metadata types that were deployed, uses Set to avoid duplicates.
       let listOfMetadataTypesDeployed: string[];
@@ -428,7 +428,11 @@ export class MetadataApiDeploy extends MetadataTransfer<
     );
     // only do event hooks if source, (NOT a metadata format) deploy
     if (this.options.components) {
-      await lifecycle.emit('scopedPostDeploy', { deployResult, orgId: this.orgId } as ScopedPostDeploy);
+      // this may not be set if you resume a deploy so that `pre` is skipped.
+      if (!this.orgId) {
+        this.orgId = connection.getAuthInfoFields().orgId;
+      }
+      await lifecycle.emit<ScopedPostDeploy>('scopedPostDeploy', { deployResult, orgId: this.orgId });
     }
     return deployResult;
   }
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-CPU-E5-2673-v3-2-40GHz/eda.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-CPU-E5-2673-v3-2-40GHz/eda.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 335.35674599997583
+    "duration": 345.28876100000343
   },
   {
     "name": "sourceToMdapi",
-    "duration": 8162.298194999981
+    "duration": 8330.387101
   },
   {
     "name": "sourceToZip",
-    "duration": 6008.431779000006
+    "duration": 5822.162848000007
   },
   {
     "name": "mdapiToSource",
-    "duration": 6042.633933999983
+    "duration": 6123.899523999979
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-CPU-E5-2673-v3-2-40GHz/lotsOfClasses.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-CPU-E5-2673-v3-2-40GHz/lotsOfClasses.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 724.9735790000123
+    "duration": 675.3449159999727
   },
   {
     "name": "sourceToMdapi",
-    "duration": 11907.511557999998
+    "duration": 11995.010080000007
   },
   {
     "name": "sourceToZip",
-    "duration": 9097.891867999977
+    "duration": 9518.928809000005
   },
   {
     "name": "mdapiToSource",
-    "duration": 7404.288763000019
+    "duration": 7432.586432000011
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-CPU-E5-2673-v3-2-40GHz/lotsOfClassesOneDir.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-CPU-E5-2673-v3-2-40GHz/lotsOfClassesOneDir.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 1204.1515890000155
+    "duration": 1170.5348080000258
   },
   {
     "name": "sourceToMdapi",
-    "duration": 18205.620580000017
+    "duration": 17969.274023000035
   },
   {
     "name": "sourceToZip",
-    "duration": 14699.381414000003
+    "duration": 14706.58613000001
   },
   {
     "name": "mdapiToSource",
-    "duration": 13408.557602000015
+    "duration": 13242.275161000027
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/eda.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/eda.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 272.83077500000945
+    "duration": 260.3101150000002
   },
   {
     "name": "sourceToMdapi",
-    "duration": 5076.5884930000175
+    "duration": 6198.695180999988
   },
   {
     "name": "sourceToZip",
-    "duration": 5100.472668000002
+    "duration": 5268.037049999999
   },
   {
     "name": "mdapiToSource",
-    "duration": 4650.940291000006
+    "duration": 4821.471162000002
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/lotsOfClasses.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/lotsOfClasses.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 516.7272080000257
+    "duration": 564.117453999992
   },
   {
     "name": "sourceToMdapi",
-    "duration": 9294.126565000013
+    "duration": 10235.299335999996
   },
   {
     "name": "sourceToZip",
-    "duration": 8794.876434000005
+    "duration": 8152.812848000001
   },
   {
     "name": "mdapiToSource",
-    "duration": 6552.890683999984
+    "duration": 6198.941200000001
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/lotsOfClassesOneDir.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/lotsOfClassesOneDir.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 922.3780599999882
+    "duration": 897.9357010000094
   },
   {
     "name": "sourceToMdapi",
-    "duration": 13860.221285000007
+    "duration": 15844.131036000006
   },
   {
     "name": "sourceToZip",
-    "duration": 12158.669913999998
+    "duration": 13365.39555299998
   },
   {
     "name": "mdapiToSource",
-    "duration": 11593.850466999982
+    "duration": 10212.036124000006
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8272CL-CPU-2-60GHz/eda.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8272CL-CPU-2-60GHz/eda.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 221.52461700001732
+    "duration": 220.44246799999382
   },
   {
     "name": "sourceToMdapi",
-    "duration": 6304.886562
+    "duration": 4607.407225999981
   },
   {
     "name": "sourceToZip",
-    "duration": 4946.4716929999995
+    "duration": 4298.981688
   },
   {
     "name": "mdapiToSource",
-    "duration": 4067.486848999979
+    "duration": 3981.727301999985
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8272CL-CPU-2-60GHz/lotsOfClasses.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8272CL-CPU-2-60GHz/lotsOfClasses.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 430.32039000000805
+    "duration": 431.20706300000893
   },
   {
     "name": "sourceToMdapi",
-    "duration": 8669.58472699998
+    "duration": 8517.160690000019
   },
   {
     "name": "sourceToZip",
-    "duration": 7142.537000999961
+    "duration": 6617.815279999981
   },
   {
     "name": "mdapiToSource",
-    "duration": 4768.5993590000435
+    "duration": 4786.344762999972
   }
 ]
diff --git a/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8272CL-CPU-2-60GHz/lotsOfClassesOneDir.json b/test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8272CL-CPU-2-60GHz/lotsOfClassesOneDir.json
@@ -1,18 +1,18 @@
 [
   {
     "name": "componentSetCreate",
-    "duration": 760.218274999992
+    "duration": 767.5156009999919
   },
   {
     "name": "sourceToMdapi",
-    "duration": 12450.632203999965
+    "duration": 12702.947856999992
   },
   {
     "name": "sourceToZip",
-    "duration": 10421.734989000019
+    "duration": 10320.687656999973
   },
   {
     "name": "mdapiToSource",
-    "duration": 8455.690346000018
+    "duration": 8968.458925999992
   }
 ]

Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,5 @@`
`6`	`6`	`"watch-files": ["src", "test"],`
`7`	`7`	`"recursive": true,`
`8`	`8`	`"reporter": "spec",`
`9`		`- "timeout": 5000`
	`9`	`+ "timeout": 10000`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -185,4 +185,4 @@`
`185`	`185`	`"output": []`
`186`	`186`	`}`
`187`	`187`	`}`
`188`		`-}`
	`188`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,18 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"name": "componentSetCreate",`
`4`		`- "duration": 335.35674599997583`
	`4`	`+ "duration": 345.28876100000343`
`5`	`5`	`},`
`6`	`6`	`{`
`7`	`7`	`"name": "sourceToMdapi",`
`8`		`- "duration": 8162.298194999981`
	`8`	`+ "duration": 8330.387101`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"name": "sourceToZip",`
`12`		`- "duration": 6008.431779000006`
	`12`	`+ "duration": 5822.162848000007`
`13`	`13`	`},`
`14`	`14`	`{`
`15`	`15`	`"name": "mdapiToSource",`
`16`		`- "duration": 6042.633933999983`
	`16`	`+ "duration": 6123.899523999979`
`17`	`17`	`}`
`18`	`18`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,18 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"name": "componentSetCreate",`
`4`		`- "duration": 724.9735790000123`
	`4`	`+ "duration": 675.3449159999727`
`5`	`5`	`},`
`6`	`6`	`{`
`7`	`7`	`"name": "sourceToMdapi",`
`8`		`- "duration": 11907.511557999998`
	`8`	`+ "duration": 11995.010080000007`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"name": "sourceToZip",`
`12`		`- "duration": 9097.891867999977`
	`12`	`+ "duration": 9518.928809000005`
`13`	`13`	`},`
`14`	`14`	`{`
`15`	`15`	`"name": "mdapiToSource",`
`16`		`- "duration": 7404.288763000019`
	`16`	`+ "duration": 7432.586432000011`
`17`	`17`	`}`
`18`	`18`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,18 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"name": "componentSetCreate",`
`4`		`- "duration": 1204.1515890000155`
	`4`	`+ "duration": 1170.5348080000258`
`5`	`5`	`},`
`6`	`6`	`{`
`7`	`7`	`"name": "sourceToMdapi",`
`8`		`- "duration": 18205.620580000017`
	`8`	`+ "duration": 17969.274023000035`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"name": "sourceToZip",`
`12`		`- "duration": 14699.381414000003`
	`12`	`+ "duration": 14706.58613000001`
`13`	`13`	`},`
`14`	`14`	`{`
`15`	`15`	`"name": "mdapiToSource",`
`16`		`- "duration": 13408.557602000015`
	`16`	`+ "duration": 13242.275161000027`
`17`	`17`	`}`
`18`	`18`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,18 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"name": "componentSetCreate",`
`4`		`- "duration": 272.83077500000945`
	`4`	`+ "duration": 260.3101150000002`
`5`	`5`	`},`
`6`	`6`	`{`
`7`	`7`	`"name": "sourceToMdapi",`
`8`		`- "duration": 5076.5884930000175`
	`8`	`+ "duration": 6198.695180999988`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"name": "sourceToZip",`
`12`		`- "duration": 5100.472668000002`
	`12`	`+ "duration": 5268.037049999999`
`13`	`13`	`},`
`14`	`14`	`{`
`15`	`15`	`"name": "mdapiToSource",`
`16`		`- "duration": 4650.940291000006`
	`16`	`+ "duration": 4821.471162000002`
`17`	`17`	`}`
`18`	`18`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,18 +1,18 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"name": "componentSetCreate",`
`4`		`- "duration": 516.7272080000257`
	`4`	`+ "duration": 564.117453999992`
`5`	`5`	`},`
`6`	`6`	`{`
`7`	`7`	`"name": "sourceToMdapi",`
`8`		`- "duration": 9294.126565000013`
	`8`	`+ "duration": 10235.299335999996`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"name": "sourceToZip",`
`12`		`- "duration": 8794.876434000005`
	`12`	`+ "duration": 8152.812848000001`
`13`	`13`	`},`
`14`	`14`	`{`
`15`	`15`	`"name": "mdapiToSource",`
`16`		`- "duration": 6552.890683999984`
	`16`	`+ "duration": 6198.941200000001`
`17`	`17`	`}`
`18`	`18`	`]`