Skip to content

Commit c62939c

Browse files
shetzelsvc-cli-bot
andauthored
fix: more types support wildcard and names (#894)
* fix: more types support wildcard and names * test: record perf --------- Co-authored-by: svc-cli-bot <[email protected]>
1 parent c026e51 commit c62939c

File tree

5 files changed

+36
-17
lines changed

5 files changed

+36
-17
lines changed

src/registry/metadataRegistry.json

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@
8181
"ignoreParentName": true,
8282
"uniqueIdElement": "fullName",
8383
"directoryName": "labels",
84+
"supportsWildcardAndName": true,
8485
"suffix": "labels"
8586
}
8687
},
@@ -199,6 +200,7 @@
199200
"directoryName": "pages",
200201
"inFolder": false,
201202
"strictDirectoryName": false,
203+
"supportsWildcardAndName": true,
202204
"strategies": {
203205
"adapter": "matchingContentFile"
204206
}
@@ -297,6 +299,7 @@
297299
"suffix": "globalValueSet",
298300
"directoryName": "globalValueSets",
299301
"inFolder": false,
302+
"supportsWildcardAndName": true,
300303
"strictDirectoryName": false
301304
},
302305
"globalpicklist": {
@@ -440,6 +443,7 @@
440443
"suffix": "reportType",
441444
"directoryName": "reportTypes",
442445
"inFolder": false,
446+
"supportsWildcardAndName": true,
443447
"strictDirectoryName": false
444448
},
445449
"report": {
@@ -488,6 +492,7 @@
488492
"suffix": "layout",
489493
"directoryName": "layouts",
490494
"inFolder": false,
495+
"supportsWildcardAndName": true,
491496
"strictDirectoryName": false
492497
},
493498
"document": {
@@ -517,6 +522,7 @@
517522
"suffix": "letter",
518523
"directoryName": "letterhead",
519524
"inFolder": false,
525+
"supportsWildcardAndName": true,
520526
"strictDirectoryName": false
521527
},
522528
"emailtemplate": {
@@ -537,6 +543,7 @@
537543
"suffix": "quickAction",
538544
"directoryName": "quickActions",
539545
"inFolder": false,
546+
"supportsWildcardAndName": true,
540547
"strictDirectoryName": false
541548
},
542549
"form": {
@@ -576,6 +583,7 @@
576583
"suffix": "tab",
577584
"directoryName": "tabs",
578585
"inFolder": false,
586+
"supportsWildcardAndName": true,
579587
"strictDirectoryName": false
580588
},
581589
"customapplicationcomponent": {
@@ -591,6 +599,7 @@
591599
"suffix": "app",
592600
"directoryName": "applications",
593601
"inFolder": false,
602+
"supportsWildcardAndName": true,
594603
"strictDirectoryName": false
595604
},
596605
"portal": {
@@ -644,6 +653,7 @@
644653
"suffix": "flow",
645654
"directoryName": "flows",
646655
"inFolder": false,
656+
"supportsWildcardAndName": true,
647657
"strictDirectoryName": false
648658
},
649659
"flowdefinition": {
@@ -652,6 +662,7 @@
652662
"suffix": "flowDefinition",
653663
"directoryName": "flowDefinitions",
654664
"inFolder": false,
665+
"supportsWildcardAndName": true,
655666
"strictDirectoryName": false
656667
},
657668
"flowtest": {
@@ -690,6 +701,7 @@
690701
"directoryName": "workflows",
691702
"inFolder": false,
692703
"strictDirectoryName": false,
704+
"supportsWildcardAndName": true,
693705
"children": {
694706
"types": {
695707
"workflowfieldupdate": {
@@ -886,6 +898,7 @@
886898
"directoryName": "objectTranslations",
887899
"inFolder": false,
888900
"strictDirectoryName": true,
901+
"supportsWildcardAndName": true,
889902
"children": {
890903
"types": {
891904
"customfieldtranslation": {
@@ -924,6 +937,7 @@
924937
"suffix": "globalValueSetTranslation",
925938
"directoryName": "globalValueSetTranslations",
926939
"inFolder": false,
940+
"supportsWildcardAndName": true,
927941
"strictDirectoryName": false
928942
},
929943
"standardvaluesettranslation": {
@@ -941,6 +955,7 @@
941955
"directoryName": "classes",
942956
"inFolder": false,
943957
"strictDirectoryName": false,
958+
"supportsWildcardAndName": true,
944959
"strategies": {
945960
"adapter": "matchingContentFile"
946961
}
@@ -994,6 +1009,7 @@
9941009
"suffix": "md",
9951010
"directoryName": "customMetadata",
9961011
"inFolder": false,
1012+
"supportsWildcardAndName": true,
9971013
"strictDirectoryName": false
9981014
},
9991015
"profilepasswordpolicy": {
@@ -1026,6 +1042,7 @@
10261042
"suffix": "remoteSite",
10271043
"directoryName": "remoteSiteSettings",
10281044
"inFolder": false,
1045+
"supportsWildcardAndName": true,
10291046
"strictDirectoryName": false
10301047
},
10311048
"csptrustedsite": {
@@ -1262,6 +1279,7 @@
12621279
"directoryName": "sharingRules",
12631280
"inFolder": false,
12641281
"strictDirectoryName": false,
1282+
"supportsWildcardAndName": true,
12651283
"children": {
12661284
"types": {
12671285
"sharingownerrule": {
@@ -1723,6 +1741,7 @@
17231741
"suffix": "pathAssistant",
17241742
"directoryName": "pathAssistants",
17251743
"inFolder": false,
1744+
"supportsWildcardAndName": true,
17261745
"strictDirectoryName": false
17271746
},
17281747
"leadconvertsettings": {

test/collections/componentSet.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -841,13 +841,13 @@ describe('ComponentSet', () => {
841841
});
842842

843843
it('should overwrite a singular name with wildcard when supportsWildcardAndName=false', async () => {
844-
const type = registry.types.apexclass;
844+
const type = registry.types.role;
845845
const set = new ComponentSet();
846846
set.add(new SourceComponent({ name: 'myType', type }));
847847
set.add(new SourceComponent({ name: '*', type }));
848848
set.add(new SourceComponent({ name: 'myType2', type }));
849849
set.add(new SourceComponent({ name: 'myType', type }));
850-
expect((await set.getObject()).Package.types).to.deep.equal([{ members: ['*'], name: 'ApexClass' }]);
850+
expect((await set.getObject()).Package.types).to.deep.equal([{ members: ['*'], name: 'Role' }]);
851851
});
852852

853853
it('should exclude child components that are not addressable as defined in the registry', async () => {
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
[
22
{
33
"name": "componentSetCreate",
4-
"duration": 260.3101150000002
4+
"duration": 315.9572469999839
55
},
66
{
77
"name": "sourceToMdapi",
8-
"duration": 6198.695180999988
8+
"duration": 7336.56904599999
99
},
1010
{
1111
"name": "sourceToZip",
12-
"duration": 5268.037049999999
12+
"duration": 5882.8369999999995
1313
},
1414
{
1515
"name": "mdapiToSource",
16-
"duration": 4821.471162000002
16+
"duration": 5457.908734999975
1717
}
18-
]
18+
]
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
[
22
{
33
"name": "componentSetCreate",
4-
"duration": 564.117453999992
4+
"duration": 635.8669369999843
55
},
66
{
77
"name": "sourceToMdapi",
8-
"duration": 10235.299335999996
8+
"duration": 11728.783694999991
99
},
1010
{
1111
"name": "sourceToZip",
12-
"duration": 8152.812848000001
12+
"duration": 11305.20595600002
1313
},
1414
{
1515
"name": "mdapiToSource",
16-
"duration": 6198.941200000001
16+
"duration": 7355.129727999971
1717
}
18-
]
18+
]
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
[
22
{
33
"name": "componentSetCreate",
4-
"duration": 897.9357010000094
4+
"duration": 1084.4185520000174
55
},
66
{
77
"name": "sourceToMdapi",
8-
"duration": 15844.131036000006
8+
"duration": 16738.053901000007
99
},
1010
{
1111
"name": "sourceToZip",
12-
"duration": 13365.39555299998
12+
"duration": 13409.415217000002
1313
},
1414
{
1515
"name": "mdapiToSource",
16-
"duration": 10212.036124000006
16+
"duration": 12112.881422000006
1717
}
18-
]
18+
]

0 commit comments

Comments
 (0)