Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possibly unnecessary attributes in Atom class, and add_atom method #316

Open
diogomart opened this issue Feb 13, 2025 · 0 comments
Open

Comments

@diogomart
Copy link
Contributor

Here are some things for consideration:

is_dummy and is_pseudo are redundant
#109 (comment)

we should probably ensure that the index of the atom in the MoleculeSetup.atoms list matches Atom.index, then we should have MoleculeSetup.add_atom behave like push in other languages: it appends to the end, and we remove options index and overwrite from add_atom.

The following should probably be removed:

Atom.graph
Atom.interaction_vectors
Atom.is_dummy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant