You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we should probably ensure that the index of the atom in the MoleculeSetup.atoms list matches Atom.index, then we should have MoleculeSetup.add_atom behave like push in other languages: it appends to the end, and we remove options index and overwrite from add_atom.
The following should probably be removed:
Atom.graphAtom.interaction_vectorsAtom.is_dummy
The text was updated successfully, but these errors were encountered:
Here are some things for consideration:
is_dummy
andis_pseudo
are redundant#109 (comment)
we should probably ensure that the index of the atom in the
MoleculeSetup.atoms
list matchesAtom.index
, then we should haveMoleculeSetup.add_atom
behave likepush
in other languages: it appends to the end, and we remove optionsindex
andoverwrite
fromadd_atom
.The following should probably be removed:
The text was updated successfully, but these errors were encountered: