Skip to content

Commit 58a33ef

Browse files
committed
fix: address CodeRabbit review comments
- Translate French comment to English in reconciler.go - Clarify value 0 behavior in documentation (uses controller-runtime default, not unlimited) - Add language specifiers to Markdown code blocks - Recommend value 1000 for near-unlimited concurrency instead of 0
1 parent 79fa021 commit 58a33ef

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

helm/operator/STACK_CONCURRENCY.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ helm install operator ./helm/operator \
2525
### Default Behavior
2626

2727
- **Default value: `5`** (good balance for most clusters)
28-
- Set to `0` to disable the limit (unlimited concurrency)
28+
- Set to `0` to use controller-runtime default (typically 1 concurrent reconciliation)
29+
- For near-unlimited concurrency, set a high value like `1000`
2930

3031
## Recommended Values
3132

@@ -82,8 +83,8 @@ helm upgrade operator ./helm/operator \
8283

8384
### Behavior
8485

85-
**Without limit (default):**
86-
```
86+
**Without limit (when set to 0):**
87+
```text
8788
Stack A ──┐
8889
Stack B ──┤
8990
Stack C ──┼─> All processed in parallel
@@ -92,7 +93,7 @@ Stack E ──┘
9293
```
9394

9495
**With limit of 5:**
95-
```
96+
```text
9697
Stack A ──┐
9798
Stack B ──┤
9899
Stack C ──┼─> Max 5 in parallel
@@ -115,7 +116,7 @@ kubectl exec -n formance-system $POD -- env | grep MAX_CONCURRENT_RECONCILES
115116
```
116117

117118
Expected output:
118-
```
119+
```text
119120
MAX_CONCURRENT_RECONCILES=5
120121
```
121122

internal/core/reconciler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ func withReconciler[T client.Object](controller ObjectController[T], opts ...Rec
234234
}
235235
}
236236

237-
// Appliquer MaxConcurrentReconciles si spécifié
237+
// Apply MaxConcurrentReconciles if specified (0 means use controller-runtime default)
238238
if options.MaxConcurrentReconciles > 0 {
239239
b = b.WithOptions(controllerconfig.Options{
240240
MaxConcurrentReconciles: options.MaxConcurrentReconciles,

0 commit comments

Comments
 (0)