Implement being able to iterate on self.conditions

Author: iciclespider

crossplane/pythonic/composite.py

@@ -449,6 +449,27 @@ def __getattr__(self, type):
     def __getitem__(self, type):
         return Condition(self, type)
 
+    def __bool__(self):
+        return bool(self._types())
+
+    def __len__(self):
+        return len(self._types())
+
+    def __iter__(self):
+        for type in self._types():
+            yield self[type]
+
+    def _types(self):
+        types = set()
+        if self._response is not None:
+            for condition in self._response.conditions:
+                if condition.type:
+                    types.add(str(condition.type))
+        for condition in self._observed.resource.status.conditions:
+            if condition.type:
+                types.add(str(condition.type))
+        return sorted(types)
+
 
 class Condition(protobuf.ProtobufValue):
     def __init__(self, conditions, type):

crossplane/pythonic/protobuf.py

@@ -81,7 +81,7 @@ def __getitem__(self, key):
             value = getattr(self._message, key)
         if value is _Unknown and field.has_default_value:
             value = field.default_value
-        if field.label == field.LABEL_REPEATED:
+        if field.is_repeated:
             if field.type == field.TYPE_MESSAGE and field.message_type.GetOptions().map_entry:
                 value = MapMessage(self, key, field.message_type.fields_by_name['value'], value, self._readOnly)
             else:

tests/fn_cases/conditions.yaml

@@ -24,6 +24,11 @@ request:
     composite: |
       class ConditionsComposite(BaseComposite):
         def compose(self):
+          assert bool(self.conditions)
+          assert len(self.conditions) == 1
+          for condition in self.conditions:
+            assert condition.type == 'Ready'
+
           self.status.compositeCondition = self.conditions.Ready
           self.status.compositeNotFound = self.conditions.Other
           self.status.composedCondition = self.resources.project.conditions.Ready
@@ -36,6 +41,10 @@ request:
           self.conditions.ConditionTrue('TrueCondition', 'we are true', True, True)
           self.conditions.DatabaseReady('Ready', 'Database is ready', True)
 
+          assert bool(self.conditions)
+          assert len(self.conditions) == 4
+          assert len(list(self.conditions)) == 4
+
 response:
   desired:
     composite:

tests/utils.py

@@ -30,7 +30,7 @@ def message_merge(message, values):
                 if isinstance(current, Struct):
                     map_merge(current, value)
                 else:
-                    if descriptor.label == descriptor.LABEL_REPEATED:
+                    if descriptor.is_repeated:
                         if descriptor.message_type.GetOptions().map_entry:
                             message_map_merge(descriptor, current, value)
                         else:
@@ -42,7 +42,7 @@ def message_merge(message, values):
                     list_merge(current, value)
                 else:
                     descriptor = message.DESCRIPTOR.fields_by_name.get(field)
-                    if descriptor.label == descriptor.LABEL_REPEATED:
+                    if descriptor.is_repeated:
                         if descriptor.message_type.GetOptions().map_entry:
                             message_map_merge(descriptor, current, value)
                         else:
@@ -115,7 +115,7 @@ def message_dict(message):
                 value = map_dict(value)
             elif field.message_type.name == 'ListValue':
                 value = list_list(value)
-            elif field.label == field.LABEL_REPEATED:
+            elif field.is_repeated:
                 if field.message_type.GetOptions().map_entry:
                     value = message_map_dict(field, value)
                 else: