Skip to content

fix: fallback to default avatar in ActivityTree #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

khushived
Copy link

@khushived khushived commented Apr 15, 2025

Description

This PR fixes a UI issue where deleted users appeared not as required.

Changes

  • Modified ActivityTree.vue : Updated logic to fallback to "Deleted User" label when activity.full_name is missing..
  • Introduced default-avatar.png in public directory.
  • Ensured the Avatar component gracefully loads the default image on deletion.

Fixes: #321

@khushived
Copy link
Author

Changes made:
Updated components to use fallback:
ActivityTree.vue
ActivityTreeShare.vue
UsersBar.vue
ListView.vue
Backend logic adjusted in files.py to avoid exposing email addresses for deleted users.
Ensured consistent avatar behaviour across activity logs, user lists, and shared items.
Minor cleanup and alignment of avatar display logic with existing UX patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor UX Issues
1 participant