Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #639 #648

Open
duzda opened this issue Feb 20, 2025 · 0 comments · May be fixed by #649
Open

Review #639 #648

duzda opened this issue Feb 20, 2025 · 0 comments · May be fixed by #649

Comments

@duzda
Copy link
Contributor

duzda commented Feb 20, 2025

PR #639 required #637 to be merged, but no changes were made after that, which reintroduced BasicSelector, that is the same as SimpleSelector, please get rid of BasicSelector. (Sorry for being late to the pary :c)
duzda added a commit to duzda/freeipa-webui that referenced this issue Feb 20, 2025
@duzda
Remove BasicSelector
12652df 
In freeipa#637 the Selector has been updated, this file got introduced by an
accident, therefore just remedying the accident.

Fixes: freeipa#648
@duzda duzda linked a pull request Feb 20, 2025 that will close this issue
Open
duzda added a commit to duzda/freeipa-webui that referenced this issue Feb 21, 2025
@duzda
Remove BasicSelector
d92310d 
In freeipa#637 the Selector has been updated, this file got introduced by an
accident, therefore just remedying the accident.

Fixes: freeipa#648
Signed-off-by: David Hanina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove BasicSelector duzda/freeipa-webui
1 participant
@duzda