Skip to content

Allow phpspec/phpspec 8 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garak opened this issue Mar 28, 2025 · 5 comments
Open

Allow phpspec/phpspec 8 #63

garak opened this issue Mar 28, 2025 · 5 comments

Comments

@garak
Copy link

garak commented Mar 28, 2025

This would allow using the latest phpspec version, which is currently dev-main / 8.0.x-dev

@jaylinski
Copy link
Member

@shulard We could update our version to v7.x-dev here and allow the dev-branch of phpspec (without doing a release).

"dev-master": "6.x-dev"

@garak
Copy link
Author

garak commented Mar 28, 2025

I was thinking of simply changing "phpspec/phpspec": "^6.0 || ^7.0" to "phpspec/phpspec": "^6.0 || ^7.0 || ^8.0"

@jaylinski
Copy link
Member

I was thinking of simply changing "phpspec/phpspec": "^6.0 || ^7.0" to "phpspec/phpspec": "^6.0 || ^7.0 || ^8.0"

That won't work because there isn't a matching ^8.0-version published yet: https://packagist.org/packages/phpspec/phpspec

@shulard
Copy link
Member

shulard commented Mar 28, 2025

@shulard We could update our version to v7.x-dev here and allow the dev-branch of phpspec (without doing a release).

If we can help testing this we must update those config.

This will allow installing PHPSpec v8 dev? Don’t we need to also update the PHPspec version constraint?

I mean updating the dev-master is only for our current library versioning. Then we also need to accept 8.x-dev for PHPspec after that?

@garak
Copy link
Author

garak commented Apr 3, 2025

I was thinking of simply changing "phpspec/phpspec": "^6.0 || ^7.0" to "phpspec/phpspec": "^6.0 || ^7.0 || ^8.0"

That won't work because there isn't a matching ^8.0-version published yet: https://packagist.org/packages/phpspec/phpspec

But it will work as soon as phpspect will publish a version, helping to be future-proof.
Moreover, it would allow testing this library with the dev-main alias of phpspec (even without a published version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants