Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 16 and Ivy #518

Closed
scurk1415 opened this issue May 5, 2023 · 21 comments
Closed

Support for Angular 16 and Ivy #518

scurk1415 opened this issue May 5, 2023 · 21 comments

Comments

@scurk1415
Copy link

scurk1415 commented May 5, 2023

The legacy ViewEngine has been deprecated and removed in Angular 16.

Please add support for Ivy compiler, as you library now breaks, with Angular 16 and blocks me from updating to the newest Angular

This likely means that the library (angular-froala-wysiwyg) which declares FroalaEditorModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Versions:
Angular: 16.0.0
angular-froala-wysiwyg: 4.0.18

Someone already made a PR for this #509

@scurk1415 scurk1415 changed the title Support for Angular 16 and Ivy support Support for Angular 16 and Ivy May 5, 2023
@canadakickass
Copy link

Our team needs this.

@IchigoWalker
Copy link

need this ASAP since Angular 16 is already there for a month

@ptomaszi
Copy link

We are in the same position. We cannot upgrade to Angular 16 because of the IVY support missing. Please resolve ASAP.

@lana-white
Copy link

This is very limiting, not being up to date with the latest, and now considering another editor. There is not much point in Froala existing if you don't update with the latest releases of Angular!

@CinkadeusBG
Copy link

Likewise. Currently seeking alternative option.

@karam1ashqar
Copy link

@harasunu-narayan can we push this

@ilyaskarim
Copy link

We have already escalated this matter internally and our development team is currently reviewing it with high priority. We expect to provide an update on this issue by early next week.

@jofrly
Copy link

jofrly commented Jun 21, 2023

We have already escalated this matter internally and our development team is currently reviewing it with high priority. We expect to provide an update on this issue by early next week.

Is there a timeline for this? This blocks our upgrade to Angular 16 too.

@Vitalyua
Copy link

Dear Team, please update on status and any estimated timelines for Angular 16 support?

@fexxdev
Copy link

fexxdev commented Jun 29, 2023

Yes please, it would be great to know some kind of ETA as our enterprise app is using Froala and we would love to update asap. Thanks!

@osahner
Copy link

osahner commented Jul 4, 2023

Can we please get an update, now?
Otherwise, we will have to look for alternatives.

@rlunaro
Copy link

rlunaro commented Jul 4, 2023

I am havin the same problem.

@osahner
Copy link

osahner commented Jul 5, 2023

I had problems with angular v16 so I did my own fork and upgraded up to v16 and switched to standalone components.
https://github.com/osahner/angular-froala-wysiwyg/tree/upgrade-to-ivy

@ilyaskarim
Copy link

We have already escalated this matter internally and our development team is currently reviewing it with high priority. We expect to provide an update on this issue by early next week.

We'll be releasing the fix for this issue in our framework upgrade on 11th July.

@osahner
Copy link

osahner commented Jul 11, 2023

... and now please publish the release :)

@sanchit-wizni
Copy link

@ilyaskarim any update on this?

@Pajchel
Copy link

Pajchel commented Jul 14, 2023

@ilyaskarim any update when the update will be added into release please? We really need the latest release ASAP.
Thanks
Tomas

@Vitalyua
Copy link

Dear Team, any ETA for Solution?

@VassilTonev
Copy link

VassilTonev commented Aug 3, 2023

I couldn't help, but smile while reading all the comments. Just 2 weeks ago the Froala team finally announced typescript definitions for the library. The issue for those was opened on Nov 22, 2017 (yes, you read it correctly, 2017).

I am really interested to see, how long it will take to release an IVY-build - something, which they should've done already, because it was more that clear that this painful moment will come, when we are not able to use the cool Angular v16 features, because we are stuck with Froala, which is a nice editor, to be fair.

Of course I am not that naive to think that older versions (we are still using 3.1.1) will get an IVY-build too.

Dear Froala team, consider this a friendly feedback. You cannot expect from you customers to tolerate this much longer.

EDIT: Just now I am realizing that the v4.1.0 release is not just adding type definitions, but also supporting IVY. However it seems like there are some major issues.

@osahner
Copy link

osahner commented Aug 3, 2023

I couldn't help, but smile while reading all the comments. Just 2 weeks ago the Froala team finally announced typescript definitions for the library. The issue for those was opened on Nov 22, 2017 (yes, you read it correctly, 2017).

...
Dear Froala team, consider this a friendly feedback. You cannot expect from you customers to tolerate this much longer.

100%

@ilyaskarim
Copy link

ilyaskarim commented Aug 23, 2023

I couldn't help, but smile while reading all the comments. Just 2 weeks ago the Froala team finally announced typescript definitions for the library. The issue for those was opened on Nov 22, 2017 (yes, you read it correctly, 2017).

I am really interested to see, how long it will take to release an IVY-build - something, which they should've done already, because it was more that clear that this painful moment will come, when we are not able to use the cool Angular v16 features, because we are stuck with Froala, which is a nice editor, to be fair.

Of course I am not that naive to think that older versions (we are still using 3.1.1) will get an IVY-build too.

Dear Froala team, consider this a friendly feedback. You cannot expect from you customers to tolerate this much longer.

EDIT: Just now I am realizing that the v4.1.0 release is not just adding type definitions, but also supporting IVY. However it seems like there are some major issues.

Thank you for taking the time to share your feedback. We completely understand your frustration with the delayed release of Typescript definitions and the IVY build for Froala. You're right that these updates have taken far too long, and I sincerely apologize for the difficulties this has caused you and other customers.
I'm very happy to let you know that we have been working diligently to resolve these issues. Froala v4.1.0 did include initial support for IVY and Typescript definitions. While there were some major issues initially, I'm pleased to say that v4.1.1 has been released and addresses the key problems with the Typescript definitions.
Please Refer: https://froala.com/wysiwyg-editor/changelog/#4.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests