Skip to content

patch: added fix for async handle not closing correctly #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

patch: added fix for async handle not closing correctly #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions adlfs/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import inspect
from typing import Optional

try:
Expand Down Expand Up @@ -81,5 +82,14 @@ async def close_credential(file_obj):
Implements asynchronous closure of credentials for
AzureBlobFile objects
"""
if not isinstance(file_obj.credential, (type(None), str)):
await file_obj.credential.close()
credential = getattr(file_obj, "credential", None)
if credential is None or isinstance(credential, str):
return

close_method = getattr(credential, "close", None)
if not callable(close_method):
return

close_result = close_method()
if inspect.isawaitable(close_result):
await close_result