fix: hide pre-launch active promotions from public slug lookups

A promotion activated ahead of its window is no longer readable via
GET /api/v1/promotions/{slug} until startsAt, matching the list
endpoint's visibility contract. Ended promotions stay visible.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: fuller-stack-dev

convex/promotions.test.ts

@@ -334,6 +334,11 @@ describe("promotions.getBySlugPublicInternal", () => {
     expect(await getBySlugHandler(ctx, { slug: base.slug, now: 150 })).toBeNull();
   });
 
+  it("hides active promotions before their launch window", async () => {
+    const ctx = makeQueryCtx({ ...base, status: "active" });
+    expect(await getBySlugHandler(ctx, { slug: base.slug, now: 50 })).toBeNull();
+  });
+
   it("returns ended promotions with active=false", async () => {
     const ctx = makeQueryCtx({ ...base, status: "ended" });
     const result = (await getBySlugHandler(ctx, { slug: base.slug, now: 150 })) as {

convex/promotions.ts

@@ -398,9 +398,11 @@ export const getBySlugPublicInternal = internalQuery({
   args: { slug: v.string(), now: v.number() },
   handler: async (ctx, args) => {
     const promotion = await getPromotionBySlug(ctx, normalizePromotionSlug(args.slug));
-    // Drafts stay hidden until launch; ended promotions remain visible so
-    // launch pages and stale CLI links can render a clear "ended" state.
+    // Drafts and pre-launch activations stay hidden so unreleased launch
+    // details cannot be read by guessing the slug; ended promotions remain
+    // visible so launch pages and stale CLI links can render an "ended" state.
     if (!promotion || promotion.status === "draft") return null;
+    if (promotion.status === "active" && args.now < promotion.startsAt) return null;
     return toPublicPromotion(promotion, args.now);
   },
 });