msr->msc_full_request_buffer is freed but not assigned to NULL. It could be freed again later

Marc Stern · Marc Stern · commit f08897003b79 · 2024-05-28T16:25:26.000+02:00
diff --git a/apache2/modsecurity.c b/apache2/modsecurity.c
@@ -330,6 +330,7 @@ static apr_status_t modsecurity_tx_cleanup(void *data) {
             msr->msc_full_request_buffer != NULL) {
         msr->msc_full_request_length = 0;
         free(msr->msc_full_request_buffer);
+        msr->msc_full_request_buffer = NULL;
     }
 
 #if defined(WITH_LUA)

Original file line number	Diff line number	Diff line change
`@@ -330,6 +330,7 @@ static apr_status_t modsecurity_tx_cleanup(void *data) {`
`330`	`330`	`msr->msc_full_request_buffer != NULL) {`
`331`	`331`	`msr->msc_full_request_length = 0;`
`332`	`332`	`free(msr->msc_full_request_buffer);`
	`333`	`+ msr->msc_full_request_buffer = NULL;`
`333`	`334`	`}`
`334`	`335`
`335`	`336`	`#if defined(WITH_LUA)`