Skip to content

Commit 56cea92

Browse files
committed
Revert "Update README and examples"
This reverts commit 83916c3.
1 parent 83916c3 commit 56cea92

File tree

2 files changed

+5
-26
lines changed

2 files changed

+5
-26
lines changed

README.md

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -28,31 +28,12 @@ This library [fixes][34] those issues in generated code, implements [paging][24]
2828

2929
## Setup
3030

31-
Set up once and use the library from any notebook, script or project:
31+
Set up environment variables and use the library from any notebook, script or project:
3232

3333
- [`DEVELOCITY_API_URL`][16]: the URL of your Develocity instance
34+
- [`DEVELOCITY_API_TOKEN`][17]: an [access key][31] for the Develocity instance
3435
- [`DEVELOCITY_API_CACHE_ENABLED`][12] (optional, off by default): enables caching for some
3536
requests (see [caveats][13])
36-
- An access key in one of the supported locations
37-
38-
<details>
39-
40-
<summary>Supported access key locations</summary>
41-
42-
Access key support matches that of official tooling: the Develocity [Gradle Plugin][37] and [Maven Extension][38].
43-
If you've already provisioned a key for your build to connect to Develocity, there's probably no action needed.
44-
Supported locations, in order of precedence:
45-
46-
- a provider function as [`Config.accessKey`][17] (see [optional setup](#optional-setup))
47-
- official tooling locations with value in format `host=key`, e.g. `DEVELOCITY_ACCESS_KEY='foo.com=my-key'`:
48-
- [`DEVELOCITY_ACCESS_KEY`](https://docs.gradle.com/develocity/gradle-plugin/current/#manual_access_key_configuration)
49-
- [`GRADLE_ENTERPRISE_ACCESS_KEY`](https://docs.gradle.com/develocity/gradle-plugin/current/#manual_access_key_configuration)
50-
- File `$GRADLE_USER_HOME/.gradle/develocity/keys.properties`, or `~/.gradle/develocity/keys.properties` if `GRADLE_USER_HOME` is not set
51-
- File `~/.m2/.develocity/keys.properties`
52-
53-
Refer to the Develocity [Gradle Plugin User Manual][37] or [Maven Extension User Manual][38] for details on these variables and files, including support for keys of multiple hosts.
54-
55-
</details>
5637

5738
### Setup snippets
5839

@@ -191,7 +172,7 @@ your own. For example:
191172
```kotlin
192173
val config = Config(
193174
apiUrl = "https://ge.mycompany.com/api/",
194-
accessKey = { vault.getDevelocityAccessKey() },
175+
apiToken = { vault.getGeApiToken() },
195176
clientBuilder = existingClient.newBuilder(),
196177
)
197178
val api = DevelocityApi.newInstance(config)
@@ -233,7 +214,7 @@ For general discussions or questions, feel free to reach out to maintainers on t
233214
[13]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api/-config/-cache-config/index.html
234215
[14]: https://central.sonatype.com/artifact/com.gabrielfeo/develocity-api-kotlin/2024.3.0
235216
[16]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api/-config/api-url.html
236-
[17]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api/-config/access-key.html
217+
[17]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api/-config/api-token.html
237218
[18]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api/-builds-api/index.html
238219
[19]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api.model/-gradle-attributes/index.html
239220
[20]: https://gabrielfeo.github.io/develocity-api-kotlin/library/com.gabrielfeo.develocity.api/-builds-api/index.html
@@ -253,5 +234,3 @@ For general discussions or questions, feel free to reach out to maintainers on t
253234
[34]: https://github.com/gabrielfeo/develocity-api-kotlin/blob/main/build-logic/src/functionalTest/kotlin/com/gabrielfeo/task/PostProcessGeneratedApiTest.kt#L21
254235
[35]: https://community.gradle.org/#community-channels
255236
[36]: ./examples/example-gradle-task/
256-
[37]: https://docs.gradle.com/develocity/gradle-plugin/current/#manual_access_key_configuration
257-
[38]: https://docs.gradle.com/develocity/maven-extension/current/#manual_access_key_configuration

examples/example-notebooks/MostFrequentBuilds.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"source": [
1010
"# Most frequent builds\n",
1111
"\n",
12-
"See what builds are most commonly invoked by developers, e.g. `clean assemble`, `test` or `check`. You can [set up the URL and an access key for your Develocity instance](https://github.com/gabrielfeo/develocity-api-kotlin/blob/main/README.md#setup) and run this notebook as-is for your own project.\n",
12+
"See what builds are most commonly invoked by developers, e.g. `clean assemble`, `test` or `check`. You can [set up the URL and a token for your Develocity instance](https://github.com/gabrielfeo/develocity-api-kotlin/blob/main/README.md#setup) and run this notebook as-is for your own project.\n",
1313
"\n",
1414
"This is a simple example of something you can do with the API. It could bring insights, for example:\n",
1515
"\n",

0 commit comments

Comments
 (0)