enable out of tree use of opengl renderer

Author: gabydd

src/ghostty.zig

@@ -6,6 +6,6 @@ pub const input = @import("input.zig");
 pub const internal_os = @import("os/main.zig");
 pub const renderer = @import("renderer.zig");
 pub const terminal = @import("terminal/main.zig");
-pub const CoreApp = @import("App.zig");
-pub const CoreSurface = @import("Surface.zig");
+pub const Surface = @import("Surface.zig");
 pub const config = @import("config.zig");
+pub const gl = @import("opengl");

src/renderer/Metal.zig

@@ -749,8 +749,9 @@ pub fn threadEnter(self: *const Metal, surface: *apprt.Surface) !void {
 }
 
 /// Callback called by renderer.Thread when it exits.
-pub fn threadExit(self: *const Metal) void {
+pub fn threadExit(self: *const Metal, surface: *apprt.Surface) void {
     _ = self;
+    _ = surface;
 
     // Metal requires no per-thread state.
 }

src/renderer/OpenGL.zig

@@ -453,7 +453,7 @@ pub fn surfaceInit(surface: *apprt.Surface) !void {
     const self: OpenGL = undefined;
 
     switch (apprt.runtime) {
-        else => @compileError("unsupported app runtime for OpenGL"),
+        else => try self.threadEnter(surface),
 
         apprt.gtk => {
             // GTK uses global OpenGL context so we load from null.
@@ -493,12 +493,13 @@ pub fn surfaceInit(surface: *apprt.Surface) !void {
 /// final main thread setup requirements.
 pub fn finalizeSurfaceInit(self: *const OpenGL, surface: *apprt.Surface) !void {
     _ = self;
-    _ = surface;
 
     // For GLFW, we grabbed the OpenGL context in surfaceInit and we
     // need to release it before we start the renderer thread.
     if (apprt.runtime == apprt.glfw) {
         glfw.makeContextCurrent(null);
+    } else if (apprt.runtime == apprt.gtk) {} else {
+        try surface.finalizeSurfaceInit();
     }
 }
 
@@ -557,7 +558,7 @@ pub fn threadEnter(self: *const OpenGL, surface: *apprt.Surface) !void {
     _ = self;
 
     switch (apprt.runtime) {
-        else => @compileError("unsupported app runtime for OpenGL"),
+        else => try surface.threadEnter(),
 
         apprt.gtk => {
             // GTK doesn't support threaded OpenGL operations as far as I can
@@ -595,11 +596,11 @@ pub fn threadEnter(self: *const OpenGL, surface: *apprt.Surface) !void {
 }
 
 /// Callback called by renderer.Thread when it exits.
-pub fn threadExit(self: *const OpenGL) void {
+pub fn threadExit(self: *const OpenGL, surface: *apprt.Surface) void {
     _ = self;
 
     switch (apprt.runtime) {
-        else => @compileError("unsupported app runtime for OpenGL"),
+        else => surface.threadExit(),
 
         apprt.gtk => {
             // We don't need to do any unloading for GTK because we may
@@ -2345,7 +2346,7 @@ pub fn drawFrame(self: *OpenGL, surface: *apprt.Surface) !void {
         apprt.glfw => surface.window.swapBuffers(),
         apprt.gtk => {},
         apprt.embedded => {},
-        else => @compileError("unsupported runtime"),
+        else => try surface.swapBuffers(),
     }
 }
 

src/renderer/Thread.zig

@@ -217,7 +217,7 @@ fn threadMain_(self: *Thread) !void {
     // renderers have to do per-thread setup. For example, OpenGL has to set
     // some thread-local state since that is how it works.
     try self.renderer.threadEnter(self.surface);
-    defer self.renderer.threadExit();
+    defer self.renderer.threadExit(self.surface);
 
     // Start the async handlers
     self.wakeup.wait(&self.loop, &self.wakeup_c, Thread, self, wakeupCallback);