Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow layers in tach.domain.toml #664

Open
shashanktomar opened this issue Mar 5, 2025 · 1 comment
Open

Allow layers in tach.domain.toml #664

shashanktomar opened this issue Mar 5, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@shashanktomar
Copy link

The layers are not supported in tech.domain.toml file. In a monorepo setup, each module can have different type of layers, so this feature will be really helpful.

@emdoyle emdoyle added the enhancement New feature or request label Mar 10, 2025
@emdoyle
Copy link
Member

emdoyle commented Mar 10, 2025

Hi @shashanktomar , thanks for raising this. I agree that scoped layers makes sense.

I'm curious about your expectations in a couple cases:

  • if you define layers in a root tach.toml, then re-define them in tach.domain.toml, would you expect that the modules within the domain can refer only to the domain's layers? or to both layers?
  • also, if I define layers in a tach.domain.toml, would you expect that other domains can refer to these layers?
  • how would you want to define layers between domains? e.g. would you still expect to be able to say 'this domain is in the "product" layer' and 'this domain internally has layers A, B, C'?

My assumption would be that the layers in tach.domain.toml essentially 'shadow' the outer layers, but to support layering the domains themselves, there might need to be additional syntax. Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants