Skip to content

Incorrect version number #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bevanjkay opened this issue Mar 19, 2025 · 4 comments · Fixed by #701
Closed

Incorrect version number #697

bevanjkay opened this issue Mar 19, 2025 · 4 comments · Fixed by #701

Comments

@bevanjkay
Copy link

Hi, Homebrew maintainer here 👋,

While regression testing the latest version, it looks like the version number was not correctly incremented to 0.28.2.

    Minitest::Assertion: Expected /0\.28\.2/ to match "tach 0.28.1\n".

Homebrew ref: Homebrew/homebrew-core#211660

@emdoyle
Copy link
Member

emdoyle commented Mar 20, 2025

Hi! Thanks for pointing this out, I actually didn't realize we were distributed through homebrew.

It looks like I forgot to bump the version constant which backs tach --version. This should be resolved in our next release, since I don't think there's anything I can do about the current version.

@emdoyle
Copy link
Member

emdoyle commented Mar 21, 2025

This will be resolved in 0.28.3 which will be released shortly!

@bollwyvl
Copy link

bollwyvl commented Apr 1, 2025

Appears to have occurred again on 0.28.5.

@emdoyle
Copy link
Member

emdoyle commented Apr 1, 2025

@bollwyvl apologies for the inconvenience. I believe @chenrui333 is addressing this for the Homebrew release (see #723) and we added tests on our end before the pypi release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants