Add local memory cache to Redis implementation to reduce roundtrips (#1214)

* Add local memory cache to Redis implementation to reduce roundtrips

* It seems better to keep GxRedis.cs unified for both .NET Framework and .NET Core.

* Applied Fazzato’s review suggestions

* Fix build error.

* Read ENABLE_MEMORY_CACHE from provider settings and apply it only in the default constructor used by CacheAPI.

* Refactor local cache settings in Redis implementation to support configurable maximum TTL and adjust local cache factor to 20%.

---------

Co-authored-by: claudiamurialdo <[email protected]>

Author: claudiamurialdo

dotnet/src/dotnetcore/GxClasses/Services/Session/GXSessionFactory.cs

@@ -19,8 +19,6 @@ public class GXSessionServiceFactory
 		private static readonly IGXLogger log = GXLoggerFactory.GetLogger<GXSessionServiceFactory>();
 
 		static ISessionService sessionService;
-		static string REDIS = "REDIS";
-		static string DATABASE = "DATABASE";
 		public static ISessionService GetProvider()
 		{
 			if (sessionService != null)
@@ -35,9 +33,9 @@ public static ISessionService GetProvider()
 					//Compatibility 
 					if (string.IsNullOrEmpty(className))
 					{
-						if (providerService.Name.Equals(REDIS, StringComparison.OrdinalIgnoreCase))
+						if (providerService.Name.Equals(GXServices.REDIS_CACHE_SERVICE, StringComparison.OrdinalIgnoreCase))
 							type = typeof(GxRedisSession);
-						else if (providerService.Name.Equals(DATABASE, StringComparison.OrdinalIgnoreCase))
+						else if (providerService.Name.Equals(GXServices.DATABASE_CACHE_SERVICE, StringComparison.OrdinalIgnoreCase))
 							type = typeof(GxDatabaseSession);
 					}
 					else

dotnet/src/dotnetcore/Providers/Cache/GxRedis/GxRedis.csproj

@@ -16,7 +16,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <Compile Include="..\..\..\..\dotnetframework\Providers\Cache\GxRedis\GxRedis.cs" Link="GxRedis.cs" />
+	<Compile Include="..\..\..\..\dotnetframework\Providers\Cache\GxRedis\GxRedis.cs" Link="GxRedis.cs" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="StackExchange.Redis" Version="2.9.17" />

dotnet/src/dotnetframework/GxClasses/Services/Storage/GXServices.cs

@@ -15,6 +15,8 @@ public class GXServices
 		public static string STORAGE_SERVICE = "Storage";
 		public static string STORAGE_APISERVICE = "StorageAPI";
 		public static string CACHE_SERVICE = "Cache";
+		public static string REDIS_CACHE_SERVICE = "Redis";
+		public static string DATABASE_CACHE_SERVICE = "DATABASE";
 		public static string DATA_ACCESS_SERVICE = "DataAccess";
 		public static string SESSION_SERVICE = "Session";
 		public static string WEBNOTIFICATIONS_SERVICE = "WebNotifications";
@@ -47,6 +49,7 @@ public static GXServices Instance
 			}
 			set { }			
 		}
+
 		public void AddService(string name, GXService service)
 		{
 			services[name] = service;