ci: revert publish env name to npm#169
Conversation
Reverts the `npm` → `Publish` rename from #168. The release workflow on `main` failed at the env protection step (custom branch policy typo `mian` blocked deployment), so we never reached `npm publish`, but the npm trusted publisher config for this package likely pins the `environment` claim to `npm` (same as cli) — renaming the env would also have broken OIDC auth. Reverting the env name in the workflow restores the previous claim shape. The recreated `npm` environment in this repo must hold `PUBLISH_CI_APP_CLIENT_ID` (variable) and `PUBLISH_CI_APP_KEY` (secret) for the App-token swap from #168 to keep working, and the deployment branch policy must be `main` (not `mian`).
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Reverts the
npm→Publishrename from #168. The release onmainfailed at env protection because the custom branch policy onPublishhad a typo (mianinstead ofmain), so the workflow never reached npm publish — but the npm trusted publisher config for this package likely pins theenvironmentclaim tonpm(same root cause as ingenlayer-cli). Reverting the env name in the workflow keeps OIDC auth working once the env is recreated.Pre-merge checklist (GitHub side)
npmenvironment with:PUBLISH_CI_APP_CLIENT_ID= same value as currently inPublishPUBLISH_CI_APP_KEY= same value as currently inPublishmain(the existingPublishenv has amiantypo — do not copy it)Publishenvironment after the newnpmenv is in placeTest plan
fix:orfeat:commit tomain(or trigger the workflow manually) and confirm npm publish succeeds