PB-1875: add tests

- Added tests to ensure that, whenever both center and features are present at startup, we prioritize the center

Author: ltkum

packages/mapviewer/tests/cypress/support/intercepts.js

@@ -251,7 +251,7 @@ let lastIdentifiedFeatures = []
  * Features IDs will start from 1 + offset (if an offset is given) and coordinates will be randomly
  * selected within the LV95 extent (or within the selection box, if one is given).
  */
-const addFeatureIdentificationIntercepts = () => {
+export function addFeatureIdentificationIntercepts(coordinates) {
     let featureTemplate = {}
     let featureDetailTemplate = {}
     cy.fixture('features/features.fixture').then((featuresFixture) => {
@@ -356,7 +356,7 @@ const addFeatureIdentificationIntercepts = () => {
                     featureDetail.bbox = [...coordinate, ...coordinate]
                     featureDetail.geometry.coordinates = [coordinate]
                 } else {
-                    const randomCoordinate = [
+                    const randomCoordinate = coordinates ?? [
                         Cypress._.random(LV95.bounds.lowerX, LV95.bounds.upperX),
                         Cypress._.random(LV95.bounds.lowerY, LV95.bounds.upperY),
                     ]

packages/mapviewer/tests/cypress/tests-e2e/featureSelection.cy.js

@@ -5,6 +5,8 @@ import proj4 from 'proj4'
 import { DEFAULT_FEATURE_COUNT_RECTANGLE_SELECTION } from '@/config/map.config'
 import { FeatureInfoPositions } from '@/store/modules/ui.store'
 
+import { addFeatureIdentificationIntercepts } from '../support/intercepts'
+
 registerProj4(proj4)
 
 describe('Testing the feature selection', () => {
@@ -69,21 +71,37 @@ describe('Testing the feature selection', () => {
             }
         }
 
-        function goToMapViewWithFeatureSelection(featureInfoPosition = null) {
+        function goToMapViewWithFeatureSelection(
+            featureInfoPosition = null,
+            featureCoordinates = null
+        ) {
             const params = {
                 layers: `${standardLayer}@features=1:2:3:4:5:6:7:8:9:10`,
             }
+            if (featureCoordinates) {
+                addFeatureIdentificationIntercepts(featureCoordinates)
+            }
             if (featureInfoPosition) {
                 params.featureInfo = featureInfoPosition
             }
-            cy.goToMapView(params)
+            cy.goToMapView(
+                params,
+                true,
+                {},
+                {
+                    addFeatureIdentificationIntercepts: () => {
+                        addFeatureIdentificationIntercepts(featureCoordinates)
+                    },
+                }
+            )
         }
 
         it('Adds pre-selected features and place the tooltip according to URL param on a narrow width screen', () => {
             cy.log('When featureInfo is not specified, we should have no tooltip visible')
             goToMapViewWithFeatureSelection()
             checkFeatures()
             checkFeatureInfoPosition(FeatureInfoPositions.NONE)
+
             // --------------------------------- WIDTH < 400 pixels ---------------------------------------
             cy.log(
                 'When using a viewport with width inferior to 400 pixels, we should always go to infobox when featureInfo is not None.'
@@ -97,6 +115,31 @@ describe('Testing the feature selection', () => {
             checkFeatures()
             checkFeatureInfoPosition(FeatureInfoPositions.BOTTOMPANEL)
         })
+        it('Centers correctly the map when pre-selected features are present', () => {
+            cy.log('We ensure that when no center is defined, we are on the center of the extent')
+            const preDefinedCenter = [2671500, 1190000]
+
+            goToMapViewWithFeatureSelection(FeatureInfoPositions.NONE, preDefinedCenter)
+
+            cy.readStoreValue('state.position.center').should((storeCenter) => {
+                expect(storeCenter.length).to.eq(2)
+                expect(storeCenter[0]).to.to.approximately(preDefinedCenter[0], 0.01)
+                expect(storeCenter[1]).to.to.approximately(preDefinedCenter[1], 0.01)
+            })
+
+            cy.log(
+                'We ensure that when a center is defined, we are on that center on application startup'
+            )
+            cy.goToMapView({
+                layers: `${standardLayer}@features=1:2:3:4:5:6:7:8:9:10`,
+                center: `${preDefinedCenter.join(',')}`,
+            })
+            cy.readStoreValue('state.position.center').should((storeCenter) => {
+                expect(storeCenter.length).to.eq(2)
+                expect(storeCenter[0]).to.to.approximately(preDefinedCenter[0], 0.01)
+                expect(storeCenter[1]).to.to.approximately(preDefinedCenter[1], 0.01)
+            })
+        })
         it.skip('Adds pre-selected features and place the tooltip according to URL param on a bigger screen', () => {
             // currently, this breaks on the CI, but works perfectly fine locally. It sets the featureInfo param
             // to 'bottomPanel', when it should be set to 'default'.
@@ -179,7 +222,7 @@ describe('Testing the feature selection', () => {
             })
             // ------------------------------------------------------------------------------------------------
             cy.log('Check that after a reload, features remain selected')
-            cy.reload()
+            cy.reload() // ISSUE HERE : WE DON'T GET THE FEATURE, BUT IT WORKS ON SITE
             cy.wait(`@featureDetail_${expectedFeatureIds[1]}`)
             cy.url().should((url) => {
                 new URLSearchParams(url.split('map')[1])