PB-2036: fixing store / URL synchronisation #1487
Draft
+91
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltkum
force-pushed
the
fix-PB-2036-url-sync
branch
from
c606b81 to
deec86e
Compare
- Issue: when changing the state through actions, the URL would not be updated. - Cause: when migrating to Pinia, we no longer had a global watch on mutations, instead they are defined by store, and we only checked on the app Readyness store. - Fix : (ugly) we subscribe every store that is needed. - New Issue: apparently we also broke the legacy parser.
ltkum
force-pushed
the
fix-PB-2036-url-sync
branch
from
deec86e to
ba8f8e1
Compare
pakb
reviewed
Nov 6, 2025
Contributor
pakb
left a comment
pakb
left a comment
There was a problem hiding this comment.
Can you try to make a Pinia plugin out of that?
This way you should be able to subscribe globally to the store, and should be able to access the Router using useRouter() inside the plugin declaration.
Just mind that a plugin will be declared/initiated each time a new store is added, so you might want to add some Singleton logic there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: when changing the state through actions, the URL would not be updated.
Cause: when migrating to Pinia, we no longer had a global watch on mutations, instead they are defined by store, and we only checked on the app Readyness store.
Fix : (ugly) we subscribe every store that is needed.
New Issue: apparently we also broke the legacy parser.
Test link