Skip to content

Commit 3665da9

Browse files
authored
fix silly logic bug in SettingChangedFilter
this would ignore the entire condition and just check if the key names matched
1 parent 29b24b5 commit 3665da9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

loader/src/loader/SettingV3.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ class SettingChangedFilterV3::Impl final {
433433
ListenerResult SettingChangedFilterV3::handle(std::function<Callback> fn, SettingChangedEventV3* event) {
434434
if (
435435
event->getSetting()->getModID() == m_impl->modID &&
436-
!m_impl->settingKey || event->getSetting()->getKey() == m_impl->settingKey
436+
(!m_impl->settingKey || event->getSetting()->getKey() == m_impl->settingKey)
437437
) {
438438
fn(event->getSetting());
439439
}

0 commit comments

Comments
 (0)