Fix docs build warnings, restore failure on warnings behavior (#954)

* Fail docs build on warnings

* Replace union types with | operator

* Remove --fail-on-warning arg for testing

* Replace optional type with union with none

* Revert "Remove --fail-on-warning arg for testing"

This reverts commit b1fd349.

Author: mfisher87

.readthedocs.yaml

@@ -40,5 +40,5 @@ build:
       html:
         - |-
           /bin/bash --login -c "cd docs && micromamba run -n jupytergis-docs \
-          python -m sphinx --keep-going --nitpicky --show-traceback --builder html --doctree-dir _build/doctrees --define language=en . \
+          python -m sphinx --fail-on-warning --keep-going --nitpicky --show-traceback --builder html --doctree-dir _build/doctrees --define language=en . \
           $READTHEDOCS_OUTPUT/html"

python/jupytergis_lab/jupytergis_lab/notebook/gis_document.py

@@ -3,7 +3,7 @@
 import json
 import logging
 from pathlib import Path
-from typing import Any, Dict, List, Literal, Optional, Union
+from typing import Any, Dict, List, Literal, Optional
 from uuid import uuid4
 import requests
 
@@ -50,7 +50,7 @@ class GISDocument(CommWidget):
 
     def __init__(
         self,
-        path: Optional[str | Path] = None,
+        path: str | Path | None = None,
         latitude: Optional[float] = None,
         longitude: Optional[float] = None,
         zoom: Optional[float] = None,
@@ -192,7 +192,7 @@ def add_vectortile_layer(
         logical_op: str | None = None,
         feature: str | None = None,
         operator: str | None = None,
-        value: Union[str, float, float] | None = None,
+        value: str | float | float | None = None,
     ):
         """
         Add a Vector Tile Layer to the document.
@@ -249,7 +249,7 @@ def add_geojson_layer(
         logical_op: str | None = None,
         feature: str | None = None,
         operator: str | None = None,
-        value: Union[str, int, float] | None = None,
+        value: str | int | float | None = None,
         color_expr=None,
     ):
         """
@@ -554,7 +554,7 @@ def add_geoparquet_layer(
         logical_op: str | None = None,
         feature: str | None = None,
         operator: str | None = None,
-        value: Union[str, int, float] | None = None,
+        value: str | int | float | None = None,
         color_expr=None,
     ):
         """
@@ -688,7 +688,7 @@ def add_filter(
         logical_op: str,
         feature: str,
         operator: str,
-        value: Union[str, int, float],
+        value: str | int | float,
     ):
         """
         Add a filter to a layer
@@ -734,7 +734,7 @@ def update_filter(
         logical_op: str,
         feature: str,
         operator: str,
-        value: Union[str, int, float],
+        value: str | int | float,
     ):
         """
         Update a filter applied to a layer
@@ -854,15 +854,15 @@ class Config:
     name: str
     type: LayerType
     visible: bool
-    parameters: Union[
-        IRasterLayer,
-        IVectorLayer,
-        IVectorTileLayer,
-        IHillshadeLayer,
-        IImageLayer,
-        IWebGlLayer,
-        IHeatmapLayer,
-    ]
+    parameters: (
+        IRasterLayer
+        | IVectorLayer
+        | IVectorTileLayer
+        | IHillshadeLayer
+        | IImageLayer
+        | IWebGlLayer
+        | IHeatmapLayer
+    )
     _parent = Optional[GISDocument]
 
     def __init__(__pydantic_self__, parent, **data: Any) -> None:  # noqa
@@ -877,16 +877,16 @@ class Config:
 
     name: str
     type: SourceType
-    parameters: Union[
-        IRasterSource,
-        IVectorTileSource,
-        IGeoJSONSource,
-        IImageSource,
-        IVideoSource,
-        IGeoTiffSource,
-        IRasterDemSource,
-        IGeoParquetSource,
-    ]
+    parameters: (
+        IRasterSource
+        | IVectorTileSource
+        | IGeoJSONSource
+        | IImageSource
+        | IVideoSource
+        | IGeoTiffSource
+        | IRasterDemSource
+        | IGeoParquetSource
+    )
     _parent = Optional[GISDocument]
 
     def __init__(__pydantic_self__, parent, **data: Any) -> None:  # noqa