Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official readthedocs action for PR preview links #341

Open
brichet opened this issue Jan 16, 2025 · 5 comments
Open

Use official readthedocs action for PR preview links #341

brichet opened this issue Jan 16, 2025 · 5 comments

Comments

@brichet
Copy link
Collaborator

brichet commented Jan 16, 2025

For the record, we should restore the Jupyterlite preview in the PR comment when available.

@martinRenou
Copy link
Member

We have a preview with rtd now, it works more reliably than the app.sharing app we had before.

@martinRenou
Copy link
Member

We could add back a message in the PR with direct link to the lite preview though, as it requires an extra click to access it right now :D

@mfisher87
Copy link
Member

Fixed here: #356 While we wait for the upstream action to accept the change, we're using a fork that supports the feature we needed :)

Please re-open if I misunderstood the need here :)

@brichet
Copy link
Collaborator Author

brichet commented Jan 17, 2025

We should probably keep this issue opened, to restore action on https://github.com/readthedocs/actions when the update is available upstream.

@brichet brichet reopened this Jan 17, 2025
@mfisher87
Copy link
Member

Sounds good!

@mfisher87 mfisher87 changed the title Restore jupyterlite preview in PR Use official readthedocs action for PR preview links Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants