Add Ion codec for kyo-schema#1659
Draft
hearnadam wants to merge 4 commits into
Draft
Conversation
…oss-platform The kyo-test migration removed the old per-module Test base and runs every shared test on JVM, JS, and Native. Bring the Ion codec PR in line: - IonTest and IonCorpusTest extend kyo.test.Test[Any]. - IonWriter.writeFloat formats through Ryu.RyuDouble (as JsonWriter already does) instead of java.lang.Double.toString, which renders 5.0 as "5" on Scala.js and broke encode parity across platforms. - IonCorpusTest reads the vendored Amazon ion-tests corpus through kyo.Path rather than JVM classpath getResourceAsStream, which does not link on Scala.js/Native. It finds the repository root by walking Path.cwd ancestors to the directory holding build.sbt, so the suite runs on all three platforms. This adds a test-scoped dependency on kyo-core (where Path lives) and enables ModuleKind.CommonJSModule for kyo-schema's JS test linking, since kyo.Path's JS backend uses node:fs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Notes