Make the recovery dialog non-cancelable #6620
Open
+9
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6616
Why is this the best possible solution? Were any other approaches considered?
When we start opening a form with entities, we place a lock on the forms database to prevent downloading updates during form filling. This lock is removed when the form is closed. However, if a savepoint existed, we displayed a dialog after locking the database but before actually opening the form. As a result, if the user dismissed the dialog by clicking outside its area, the lock was never removed.
The simplest solution is to make the dialog non-cancelable, preventing this issue altogether. Another approach would be to remove the lock when the dialog is canceled, but is there any reason to keep it cancelable? I don't think so, which makes the first solution simpler.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think we can simply verify that the described issue no longer exists. Also, please check if making the recovery dialog non-cancelable causes any problems (I hope not but let's double-check). That should be sufficient.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with entities.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest