test: Remove try! from tests (#6811)

philipphofmann · web-flow · commit 25d9b585d3a0 · 2025-11-18T12:46:45.000+01:00
Remove remaining try! and enable swiftlint rule. Fixes GH-4865
diff --git a/SentryTestUtils/Sources/TestClient.swift b/SentryTestUtils/Sources/TestClient.swift
@@ -3,6 +3,7 @@ import Foundation
 @_spi(Private) @testable import Sentry
 
 public class TestClient: SentryClientInternal {
+
     public override init?(options: NSObject) {
         super.init(
             options: options,
diff --git a/Tests/.swiftlint.yml b/Tests/.swiftlint.yml
@@ -18,7 +18,6 @@ custom_rules:
 
 disabled_rules:
   - force_cast
-  - force_try
   - force_unwrapping
   - function_body_length
   - identifier_name
diff --git a/Tests/SentryTests/Integrations/Session/SentrySessionGeneratorTests.swift b/Tests/SentryTests/Integrations/Session/SentrySessionGeneratorTests.swift
@@ -21,9 +21,9 @@ class SentrySessionGeneratorTests: NotificationCenterTestCase {
     private var options: Options!
     private var fileManager: SentryFileManager!
     
-    override func setUp() {
-        super.setUp()
-        
+    override func setUpWithError() throws {
+        try super.setUpWithError()
+
         options = Options()
         options.dsn = TestConstants.realDSN
         
@@ -35,11 +35,11 @@ class SentrySessionGeneratorTests: NotificationCenterTestCase {
         // We want to start and stop the SentryAutoSessionTrackingIntegration ourselves so we can send crashed and abnormal sessions.
         options.enableAutoSessionTracking = false
 
-        fileManager = try! SentryFileManager(
+        fileManager = try XCTUnwrap(SentryFileManager(
             options: options,
             dateProvider: TestCurrentDateProvider(),
             dispatchQueueWrapper: TestSentryDispatchQueueWrapper()
-        )
+        ))
 
         fileManager.deleteCurrentSession()
         fileManager.deleteCrashedSession()
diff --git a/Tests/SentryTests/Integrations/Session/SentrySessionTrackerTests.swift b/Tests/SentryTests/Integrations/Session/SentrySessionTrackerTests.swift
@@ -23,15 +23,17 @@ class SentrySessionTrackerTests: XCTestCase {
         }
         let notificationCenter = TestNSNotificationCenterWrapper()
         let dispatchQueue = TestSentryDispatchQueueWrapper()
-        lazy var fileManager = try! SentryFileManager(options: options, dateProvider: currentDateProvider, dispatchQueueWrapper: dispatchQueue)
-        
-        init() {
+        let fileManager: SentryFileManager
+
+        init() throws {
             options = Options()
             options.dsn = SentrySessionTrackerTests.dsnAsString
             options.releaseName = "SentrySessionTrackerIntegrationTests"
             options.sessionTrackingIntervalMillis = 10_000
             options.environment = "debug"
-            
+
+            fileManager = try XCTUnwrap(SentryFileManager(options: options, dateProvider: currentDateProvider, dispatchQueueWrapper: dispatchQueue))
+
             client = TestClient(options: options)
             
             sentryCrash = TestSentryCrashWrapper(processInfoWrapper: ProcessInfo.processInfo)
@@ -69,10 +71,10 @@ class SentrySessionTrackerTests: XCTestCase {
         clearTestState()
     }
     
-    override func setUp() {
-        super.setUp()
-        
-        fixture = Fixture()
+    override func setUpWithError() throws {
+        try super.setUpWithError()
+
+        fixture = try Fixture()
 
         SentryDependencyContainer.sharedInstance().dateProvider = fixture.currentDateProvider
 
diff --git a/Tests/SentryTests/Integrations/SessionReplay/SentryVideoFrameProcessorTests.swift b/Tests/SentryTests/Integrations/SessionReplay/SentryVideoFrameProcessorTests.swift
@@ -418,8 +418,8 @@ class SentryVideoFrameProcessorTests: XCTestCase {
         }
     }
 
-    func testFinishVideo_WhenSelfIsDeallocated_ShouldReturnNilVideoInfo() {
-        let delayedVideoWriter = try! DelayedTestAVAssetWriter(url: fixture.outputFileURL, fileType: .mp4)
+    func testFinishVideo_WhenSelfIsDeallocated_ShouldReturnNilVideoInfo() throws {
+        let delayedVideoWriter = try XCTUnwrap(DelayedTestAVAssetWriter(url: fixture.outputFileURL, fileType: .mp4))
         delayedVideoWriter.statusOverride = .completed
         let videoWriterInput = TestAVAssetWriterInput(mediaType: .video, outputSettings: nil)
         delayedVideoWriter.add(videoWriterInput)
diff --git a/Tests/SentryTests/Integrations/UIEvents/SentryUIEventTrackerTests.swift b/Tests/SentryTests/Integrations/UIEvents/SentryUIEventTrackerTests.swift
@@ -126,7 +126,7 @@ class SentryUIEventTrackerTests: XCTestCase {
         
         callExecuteAction(action: action, target: fixture.target, sender: button, event: TestUIEvent())
         
-        let span = try! XCTUnwrap(SentrySDK.span as? SentryTracer)
+        let span = try XCTUnwrap(SentrySDK.span as? SentryTracer)
         XCTAssertFalse(span.tags.contains {
             $0.key == "accessibilityIdentifier"
         })
@@ -150,7 +150,7 @@ class SentryUIEventTrackerTests: XCTestCase {
         try assertTransaction(name: "SentryTests.FirstViewController.\(expectedAction)", operation: operationClick)
     }
     
-    func test_OnGoingUILoadTransaction_StartNewUIEventTransaction_NotBoundToScope() {
+    func test_OnGoingUILoadTransaction_StartNewUIEventTransaction_NotBoundToScope() throws {
         // Arrange
         let uiLoadTransaction = SentrySDK.startTransaction(name: "test", operation: "ui.load", bindToScope: true)
         
@@ -159,10 +159,10 @@ class SentryUIEventTrackerTests: XCTestCase {
         
         // Assert
         XCTAssertTrue(uiLoadTransaction === SentrySDK.span)
-        XCTAssertEqual(getInternalTransactions().count, 0, "There shouldn't be an active ongoing UI event transaction.")
+        XCTAssertEqual(try getInternalTransactions().count, 0, "There shouldn't be an active ongoing UI event transaction.")
     }
     
-    func test_ManualTransactionOnScope_StartNewUIEventTransaction_NotBoundToScope() {
+    func test_ManualTransactionOnScope_StartNewUIEventTransaction_NotBoundToScope() throws {
         // Arrange
         let manualTransaction = SentrySDK.startTransaction(name: "test", operation: "my.operation", bindToScope: true)
         
@@ -171,7 +171,7 @@ class SentryUIEventTrackerTests: XCTestCase {
         
         // Assert
         XCTAssertTrue(manualTransaction === SentrySDK.span)
-        XCTAssertEqual(getInternalTransactions().count, 0, "There shouldn't be an active ongoing UI event transaction.")
+        XCTAssertEqual(try getInternalTransactions().count, 0, "There shouldn't be an active ongoing UI event transaction.")
     }
     
     func test_SameUIElementWithSameEvent_ResetsTimeout() throws {
@@ -239,16 +239,18 @@ class SentryUIEventTrackerTests: XCTestCase {
 
         callExecuteAction(action: "otherAction", target: fixture.target, sender: UIView(), event: TestUIEvent())
         
-        XCTAssertEqual(2, getInternalTransactions().count)
-        
+        XCTAssertEqual(2, try getInternalTransactions().count)
+
         let secondTransaction = try XCTUnwrap(SentrySDK.span as? SentryTracer)
-        
-        XCTAssertTrue(secondTransaction === getInternalTransactions().last)
-        
+
+        let internalTransactions1 = try getInternalTransactions()
+        XCTAssertTrue(secondTransaction === internalTransactions1.last)
+
         child.finish()
-        
-        XCTAssertEqual(1, getInternalTransactions().count)
-        XCTAssertTrue(secondTransaction === getInternalTransactions().last)
+
+        let internalTransactions2 = try getInternalTransactions()
+        XCTAssertEqual(1, internalTransactions2.count)
+        XCTAssertTrue(secondTransaction === internalTransactions2.last)
     }
     
     func test_Stop() {
@@ -273,8 +275,8 @@ class SentryUIEventTrackerTests: XCTestCase {
         fixture.swizzleWrapper.execute(action: action, target: target, sender: sender, event: event)
     }
     
-    private func getInternalTransactions() -> [SentryTracer] {
-        return try! XCTUnwrap(Dynamic(self.fixture.uiEventTrackerMode).activeTransactions.asArray as? [SentryTracer])
+    private func getInternalTransactions() throws -> [SentryTracer] {
+        return try XCTUnwrap(Dynamic(self.fixture.uiEventTrackerMode).activeTransactions.asArray as? [SentryTracer])
     }
     
     private func assertTransaction(name: String, operation: String, nameSource: SentryTransactionNameSource = .component) throws {
@@ -304,7 +306,7 @@ class SentryUIEventTrackerTests: XCTestCase {
         XCTAssertEqual(.ok, transaction.status)
         try assertTransaction(name: "SentryTests.FirstViewController.\(expectedAction)", operation: operation)
         
-        let transactions = getInternalTransactions()
+        let transactions = try getInternalTransactions()
         XCTAssertEqual(1, transactions.count)
     }
     
diff --git a/Tests/SentryTests/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackerTests.swift b/Tests/SentryTests/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackerTests.swift
@@ -28,7 +28,7 @@ class SentryWatchdogTerminationTrackerTests: NotificationCenterTestCase {
             options.dsn = SentryWatchdogTerminationTrackerTests.dsnAsString
             options.releaseName = TestData.appState.releaseName
             
-            fileManager = try! SentryFileManager(options: options, dateProvider: currentDate, dispatchQueueWrapper: dispatchQueue)
+            fileManager = try XCTUnwrap(SentryFileManager(options: options, dateProvider: currentDate, dispatchQueueWrapper: dispatchQueue))
 
             breadcrumbProcessor = SentryWatchdogTerminationBreadcrumbProcessor(maxBreadcrumbs: Int(options.maxBreadcrumbs), fileManager: fileManager)
             let backgroundQueueWrapper = TestSentryDispatchQueueWrapper()
@@ -412,7 +412,7 @@ class SentryWatchdogTerminationTrackerTests: NotificationCenterTestCase {
     }
     
     func testStop_StopsObserving_NoMoreFileManagerInvocations() throws {
-        let fileManager = try! TestFileManager(options: Options(), dateProvider: fixture.currentDate, dispatchQueueWrapper: fixture.dispatchQueue)
+        let fileManager = try XCTUnwrap(TestFileManager(options: Options(), dateProvider: fixture.currentDate, dispatchQueueWrapper: fixture.dispatchQueue))
         sut = try fixture.getSut(fileManager: fileManager)
 
         sut.start()
diff --git a/Tests/SentryTests/Networking/SentryHttpTransportTests.swift b/Tests/SentryTests/Networking/SentryHttpTransportTests.swift
@@ -59,17 +59,17 @@ class SentryHttpTransportTests: XCTestCase {
             eventEnvelope = SentryEnvelope(id: event.eventId, items: [SentryEnvelopeItem(event: event), attachmentEnvelopeItem])
             // We are comparing byte data and the `sentAt` header is also set in the transport, so we also need them here in the expected envelope.
             eventEnvelope.header.sentAt = currentDateProvider.date()
-            eventWithAttachmentRequest = buildRequest(eventEnvelope)
-            
+            eventWithAttachmentRequest = try buildRequest(eventEnvelope)
+
             session = SentrySession(releaseName: "2.0.1", distinctId: "some-id")
             sessionEnvelope = SentryEnvelope(id: nil, singleItem: SentryEnvelopeItem(session: session))
             sessionEnvelope.header.sentAt = currentDateProvider.date()
-            sessionRequest = buildRequest(sessionEnvelope)
+            sessionRequest = try buildRequest(sessionEnvelope)
 
             let items = [SentryEnvelopeItem(event: event), SentryEnvelopeItem(session: session)]
             eventWithSessionEnvelope = SentryEnvelope(id: event.eventId, items: items)
             eventWithSessionEnvelope.header.sentAt = currentDateProvider.date()
-            eventWithSessionRequest = buildRequest(eventWithSessionEnvelope)
+            eventWithSessionRequest = try buildRequest(eventWithSessionEnvelope)
 
             options = Options()
             options.dsn = SentryHttpTransportTests.dsnAsString
@@ -97,7 +97,7 @@ class SentryHttpTransportTests: XCTestCase {
             ]
             clientReportEnvelope = SentryEnvelope(id: event.eventId, items: clientReportEnvelopeItems)
             clientReportEnvelope.header.sentAt = currentDateProvider.date()
-            clientReportRequest = buildRequest(clientReportEnvelope)
+            clientReportRequest = try buildRequest(clientReportEnvelope)
         }
         
         func getTransactionEnvelope() -> SentryEnvelope {
@@ -148,9 +148,9 @@ class SentryHttpTransportTests: XCTestCase {
         try TestConstants.dsn(username: "SentryHttpTransportTests")
     }
 
-    private class func buildRequest(_ envelope: SentryEnvelope) -> URLRequest {
-        let envelopeData = try! XCTUnwrap(SentrySerializationSwift.data(with: envelope))
-        return try! SentryURLRequestFactory.envelopeRequest(with: dsn(), data: envelopeData)
+    private class func buildRequest(_ envelope: SentryEnvelope) throws -> URLRequest {
+        let envelopeData = try XCTUnwrap(SentrySerializationSwift.data(with: envelope))
+        return try SentryURLRequestFactory.envelopeRequest(with: dsn(), data: envelopeData)
     }
 
     private var fixture: Fixture!
@@ -241,7 +241,7 @@ class SentryHttpTransportTests: XCTestCase {
         ]
         let envelope = SentryEnvelope(id: fixture.event.eventId, items: envelopeItems)
         envelope.header.sentAt = fixture.currentDateProvider.date()
-        let request = SentryHttpTransportTests.buildRequest(envelope)
+        let request = try SentryHttpTransportTests.buildRequest(envelope)
 
         let actualData = try XCTUnwrap(request.httpBody)
         let expectedData = try XCTUnwrap(fixture.requestManager.requests.last?.httpBody)
@@ -470,7 +470,7 @@ class SentryHttpTransportTests: XCTestCase {
         let sessionEnvelope = SentryEnvelope(id: fixture.event.eventId, singleItem: SentryEnvelopeItem(session: fixture.session))
         sessionEnvelope.header.sentAt = fixture.currentDateProvider.date()
         let sessionData = try XCTUnwrap(SentrySerializationSwift.data(with: sessionEnvelope))
-        let sessionRequest = try! SentryURLRequestFactory.envelopeRequest(with: SentryHttpTransportTests.dsn(), data: sessionData)
+        let sessionRequest = try XCTUnwrap(SentryURLRequestFactory.envelopeRequest(with: SentryHttpTransportTests.dsn(), data: sessionData))
 
         if fixture.requestManager.requests.invocations.count > 3 {
             let unzippedBody = try XCTUnwrap(sentry_unzippedData(XCTUnwrap(sessionRequest.httpBody)))
@@ -564,8 +564,8 @@ class SentryHttpTransportTests: XCTestCase {
         ]
         let clientReportEnvelope = SentryEnvelope(id: fixture.event.eventId, items: clientReportEnvelopeItems)
         clientReportEnvelope.header.sentAt = fixture.currentDateProvider.date()
-        let clientReportRequest = SentryHttpTransportTests.buildRequest(clientReportEnvelope)
-        
+        let clientReportRequest = try SentryHttpTransportTests.buildRequest(clientReportEnvelope)
+
         givenRateLimitResponse(forCategory: "error")
         sendEvent()
         sendEvent()
@@ -592,8 +592,8 @@ class SentryHttpTransportTests: XCTestCase {
         
         let clientReportEnvelope = SentryEnvelope(id: transactionEnvelope.header.eventId, items: clientReportEnvelopeItems)
         clientReportEnvelope.header.sentAt = fixture.currentDateProvider.date()
-        let clientReportRequest = SentryHttpTransportTests.buildRequest(clientReportEnvelope)
-        
+        let clientReportRequest = try SentryHttpTransportTests.buildRequest(clientReportEnvelope)
+
         givenRateLimitResponse(forCategory: "transaction")
         
         sut.send(envelope: transactionEnvelope)
diff --git a/Tests/SentryTests/Networking/SentryTransportFactoryTests.swift b/Tests/SentryTests/Networking/SentryTransportFactoryTests.swift
@@ -19,11 +19,11 @@ class SentryTransportFactoryTests: XCTestCase {
         options.dsn = SentryTransportFactoryTests.dsnAsString
         options.urlSessionDelegate = urlSessionDelegateSpy
         
-        let fileManager = try! SentryFileManager(
+        let fileManager = try XCTUnwrap(SentryFileManager(
             options: options,
             dateProvider: dateProvider,
             dispatchQueueWrapper: TestSentryDispatchQueueWrapper()
-        )
+        ))
 
         // -- Act --
         let transports = TransportInitializer.initTransports(
@@ -59,11 +59,11 @@ class SentryTransportFactoryTests: XCTestCase {
         options.dsn = SentryTransportFactoryTests.dsnAsString
         options.urlSession = sessionConfiguration
         
-        let fileManager = try! SentryFileManager(
+        let fileManager = try XCTUnwrap(SentryFileManager(
             options: options,
             dateProvider: dateProvider,
             dispatchQueueWrapper: TestSentryDispatchQueueWrapper()
-        )
+        ))
 
         // -- Act --
         let transports = TransportInitializer.initTransports(
diff --git a/Tests/SentryTests/Networking/SentryTransportInitializerTests.swift b/Tests/SentryTests/Networking/SentryTransportInitializerTests.swift
@@ -10,15 +10,16 @@ class SentryTransportInitializerTests: XCTestCase {
     private var dateProvider: TestCurrentDateProvider!
     private var rateLimits: (any RateLimits)!
 
-    override func setUp() {
-        super.setUp()
+    override func setUpWithError() throws {
+        try super.setUpWithError()
+
         let options = Options()
         options.dsn = SentryTransportInitializerTests.dsnAsString
-        fileManager = try! SentryFileManager(
+        fileManager = try XCTUnwrap(SentryFileManager(
             options: options,
             dateProvider: TestCurrentDateProvider(),
             dispatchQueueWrapper: TestSentryDispatchQueueWrapper()
-        )
+        ))
         dateProvider = TestCurrentDateProvider()
         rateLimits = SentryDependencyContainer.sharedInstance().rateLimits
     }
diff --git a/Tests/SentryTests/PrivateSentrySDKOnlyTests.swift b/Tests/SentryTests/PrivateSentrySDKOnlyTests.swift
@@ -37,7 +37,7 @@ class PrivateSentrySDKOnlyTests: XCTestCase {
         
         let storedEnvelope = client?.storedEnvelopeInvocations.first
         let attachedSessionData = try XCTUnwrap(storedEnvelope!.items.last!.data)
-        let attachedSession = try XCTUnwrap(try! JSONSerialization.jsonObject(with: attachedSessionData) as? [String: Any])
+        let attachedSession = try XCTUnwrap(try JSONSerialization.jsonObject(with: attachedSessionData) as? [String: Any])
         
         XCTAssertEqual(0, hub.startSessionInvocations)
         // Assert crashed session was attached to the envelope
@@ -68,7 +68,7 @@ class PrivateSentrySDKOnlyTests: XCTestCase {
 
         let capturedEnvelope = client?.captureEnvelopeInvocations.first
         let attachedSessionData = try XCTUnwrap(capturedEnvelope!.items.last!.data)
-        let attachedSession = try XCTUnwrap(try! JSONSerialization.jsonObject(with: attachedSessionData) as? [String: Any])
+        let attachedSession = try XCTUnwrap(try JSONSerialization.jsonObject(with: attachedSessionData) as? [String: Any])
         
         // Assert new session was started
         XCTAssertEqual(1, hub.startSessionInvocations)
diff --git a/Tests/SentryTests/Protocol/SentryEnvelopeTests.swift b/Tests/SentryTests/Protocol/SentryEnvelopeTests.swift
@@ -78,7 +78,7 @@ class SentryEnvelopeTests: XCTestCase {
         XCTAssertEqual(1, envelope.items.count)
         XCTAssertEqual("event", try XCTUnwrap(envelope.items.first).header.type)
         
-        let json = try! JSONSerialization.data(withJSONObject: event.serialize(), options: JSONSerialization.WritingOptions(rawValue: 0))
+        let json = try XCTUnwrap(JSONSerialization.data(withJSONObject: event.serialize(), options: JSONSerialization.WritingOptions(rawValue: 0)))
         
         assertJsonIsEqual(actual: json, expected: try XCTUnwrap(XCTUnwrap(envelope.items.first).data))
     }
diff --git a/Tests/SentryTests/Protocol/SentrySDKSettingsTests.swift b/Tests/SentryTests/Protocol/SentrySDKSettingsTests.swift
@@ -12,12 +12,12 @@ class SentrySDKSettingsTests: XCTestCase {
         XCTAssertFalse(settings.autoInferIP)
     }
     
-    func testInitWithOptions_WhenSendDefaultPiiTrue_SetsAutoInferIPToTrue() {
-        let options = try! SentryOptionsInternal.initWithDict([
+    func testInitWithOptions_WhenSendDefaultPiiTrue_SetsAutoInferIPToTrue() throws {
+        let options = try XCTUnwrap(SentryOptionsInternal.initWithDict([
             "dsn": "https://username:password@app.getsentry.com/12345",
             "sendDefaultPii": true
-        ])
-        
+        ]))
+
         XCTAssertNotNil(options)
         
         let settings = SentrySDKSettings(options: options)
@@ -26,12 +26,12 @@ class SentrySDKSettingsTests: XCTestCase {
         XCTAssertTrue(settings.autoInferIP)
     }
     
-    func testInitWithOptions_WhenSendDefaultPiiFalse_SetsAutoInferIPToFalse() {
-        let options = try! SentryOptionsInternal.initWithDict([
+    func testInitWithOptions_WhenSendDefaultPiiFalse_SetsAutoInferIPToFalse() throws {
+        let options = try XCTUnwrap(SentryOptionsInternal.initWithDict([
             "dsn": "https://username:password@app.getsentry.com/12345",
             "sendDefaultPii": false
-        ])
-        
+        ]))
+
         XCTAssertNotNil(options)
         
         let settings = SentrySDKSettings(options: options)
diff --git a/Tests/SentryTests/SentryNSURLRequestTests.swift b/Tests/SentryTests/SentryNSURLRequestTests.swift
diff --git a/Tests/SentryTests/SentrySDKInternalTests.swift b/Tests/SentryTests/SentrySDKInternalTests.swift
diff --git a/Tests/SentryTests/SentrySDKTests.swift b/Tests/SentryTests/SentrySDKTests.swift

Original file line number	Diff line number	Diff line change
`@@ -418,8 +418,8 @@ class SentryVideoFrameProcessorTests: XCTestCase {`
`418`	`418`	`}`
`419`	`419`	`}`
`420`	`420`
`421`		`- func testFinishVideo_WhenSelfIsDeallocated_ShouldReturnNilVideoInfo() {`
`422`		`- let delayedVideoWriter = try! DelayedTestAVAssetWriter(url: fixture.outputFileURL, fileType: .mp4)`
	`421`	`+ func testFinishVideo_WhenSelfIsDeallocated_ShouldReturnNilVideoInfo() throws {`
	`422`	`+ let delayedVideoWriter = try XCTUnwrap(DelayedTestAVAssetWriter(url: fixture.outputFileURL, fileType: .mp4))`
`423`	`423`	`delayedVideoWriter.statusOverride = .completed`
`424`	`424`	`let videoWriterInput = TestAVAssetWriterInput(mediaType: .video, outputSettings: nil)`
`425`	`425`	`delayedVideoWriter.add(videoWriterInput)`