Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing layoutSubviews spans for non animating viewControllers transaction #1506

Open
brustolin opened this issue Dec 2, 2021 · 5 comments

Comments

@brustolin
Copy link
Contributor

brustolin commented Dec 2, 2021

When a new viewController is presented without animation the ui life cycle changes.
With animation, the last method to be called is viewDidAppear, and we finish the transaction in this one.
Without animation, methods related to layout subviews are called after viewDidAppear, and we don't measure them.
Depending on the the amount of subviews, those methods can take a while, and thats why is important to measure them.

@philipphofmann
Copy link
Member

philipphofmann commented Dec 22, 2021

We could solve this with waitWithTimeout similar as we have it on Flutter and JavaScript. Maybe we can also detect in the run loop or through screen rendering when the UIViewController finishes.

@philipphofmann philipphofmann moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Dec 22, 2021
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@brustolin
Copy link
Contributor Author

I believe this need to be on backlog.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@philipphofmann
Copy link
Member

Is this still an issue @brustolin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants